Skip to content

Conversation

kassens
Copy link
Member

@kassens kassens commented Apr 19, 2024

Reverts #28867

It broke some tests, reverting until we figure out why to avoid having too much delay in the sync.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 19, 2024
@react-sizebot
Copy link

Comparing: 33a3244...625cf29

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.91 kB 168.92 kB +0.01% 52.94 kB 52.94 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 170.56 kB 170.57 kB +0.02% 53.43 kB 53.44 kB
facebook-www/ReactDOM-prod.classic.js = 590.81 kB 590.83 kB = 103.90 kB 103.91 kB
facebook-www/ReactDOM-prod.modern.js = 566.62 kB 566.65 kB = 100.09 kB 100.10 kB
test_utils/ReactAllWarnings.js Deleted 64.44 kB 0.00 kB Deleted 16.10 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react/cjs/react.production.js +0.34% 35.36 kB 35.48 kB +0.11% 10.03 kB 10.04 kB
oss-stable/react/cjs/react.production.js +0.34% 35.39 kB 35.51 kB +0.11% 10.06 kB 10.07 kB
oss-experimental/react/cjs/react.production.js +0.32% 37.04 kB 37.16 kB +0.08% 10.41 kB 10.42 kB
test_utils/ReactAllWarnings.js Deleted 64.44 kB 0.00 kB Deleted 16.10 kB 0.00 kB

Generated by 🚫 dangerJS against 625cf29

@kassens kassens merged commit f5ce642 into main Apr 19, 2024
@kassens kassens deleted the revert-28867-make-inst-refs-writable branch April 19, 2024 16:35
github-actions bot pushed a commit that referenced this pull request Apr 19, 2024
Reverts #28867

It broke some tests, reverting until we figure out why to avoid having
too much delay in the sync.

DiffTrain build for commit f5ce642.
github-actions bot pushed a commit that referenced this pull request Apr 19, 2024
Reverts #28867

It broke some tests, reverting until we figure out why to avoid having
too much delay in the sync.

DiffTrain build for [f5ce642](f5ce642)
kassens added a commit that referenced this pull request Apr 19, 2024
kassens added a commit that referenced this pull request Apr 23, 2024
kassens added a commit that referenced this pull request Apr 24, 2024
Reverts #28877

We found the cause of the regression and should be able to land this
again.
github-actions bot pushed a commit that referenced this pull request Apr 24, 2024
Reverts #28877

We found the cause of the regression and should be able to land this
again.

DiffTrain build for commit b039be6.
github-actions bot pushed a commit that referenced this pull request Apr 24, 2024
Reverts #28877

We found the cause of the regression and should be able to land this
again.

DiffTrain build for [b039be6](b039be6)
bigfootjon pushed a commit that referenced this pull request Apr 25, 2024
Reverts #28867

It broke some tests, reverting until we figure out why to avoid having
too much delay in the sync.

DiffTrain build for commit f5ce642.
Akshato07 pushed a commit to Akshato07/-Luffy that referenced this pull request Feb 20, 2025
Reverts facebook/react#28877

We found the cause of the regression and should be able to land this
again.

DiffTrain build for commit facebook/react@b039be6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants