Skip to content

Devtools:-Removed unused CSS #27032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Devtools:-Removed unused CSS #27032

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2bc25f
Removed unused CSS
Biki-das Jul 1, 2023
07b7b6d
Fixed wrong CSS class Name
Biki-das Jul 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/react-devtools-shared/src/devtools/views/Components/EditableValue.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,3 @@
background-color: var(--color-button-background-focus);
outline: none;
}

.ResetButton {
flex: 0 0 auto;
padding: 0 0.5rem;
}
5 changes: 0 additions & 5 deletions packages/react-devtools-shared/src/devtools/views/Components/Element.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@
user-select: none;
}

.ScrollAnchor {
height: 100%;
width: 0;
}

.SelectedElement {
background-color: var(--color-background-selected);
color: var(--color-text-selected);
Expand Down
14 changes: 2 additions & 12 deletions packages/react-devtools-shared/src/devtools/views/Components/InspectedElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,25 +263,19 @@ export default function InspectedElementWrapper(_: Props): React.Node {
<div className={styles.SelectedComponentName}>
<div
className={
element.isStrictModeNonCompliant
? styles.StrictModeNonCompliantComponent
: styles.Component
element.isStrictModeNonCompliant ? undefined : styles.Component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there was a typo in #22886

so the right fix would be:

Suggested change
element.isStrictModeNonCompliant ? undefined : styles.Component
element.isStrictModeNonCompliant ? styles.StrictModeNonCompliant : styles.Component

could you please update and verify that?

Other changes are fine, maybe we should explore supporting this eslint rule for react-devtools-* packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sure, :-)

Copy link
Contributor Author

@Biki-das Biki-das Jul 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoxyq i thought of supporting the same, but the library is an unmaintained one, the last update was 4 years ago.? is it fine to use such library ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes you are correct, it was a small typo!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What library are you referring to there? Sorry, didn't get that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you mean eslint plugin. Maybe there is a maintained one, which has the same purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @hoxyq meanwhile we can merge this one if its okay and let me research if there is something similar :-)

}
title={element.displayName}>
{element.displayName}
</div>
</div>
{canOpenInEditor && (
<Button
className={styles.IconButton}
onClick={onOpenInEditor}
title="Open in editor">
<Button onClick={onOpenInEditor} title="Open in editor">
<ButtonIcon type="editor" />
</Button>
)}
{canToggleError && (
<Toggle
className={styles.IconButton}
isChecked={isErrored}
onChange={toggleErrored}
title={
Expand All @@ -294,7 +288,6 @@ export default function InspectedElementWrapper(_: Props): React.Node {
)}
{canToggleSuspense && (
<Toggle
className={styles.IconButton}
isChecked={isSuspended}
onChange={toggleSuspended}
title={
Expand All @@ -307,23 +300,20 @@ export default function InspectedElementWrapper(_: Props): React.Node {
)}
{store.supportsNativeInspection && (
<Button
className={styles.IconButton}
onClick={highlightElement}
title="Inspect the matching DOM element">
<ButtonIcon type="view-dom" />
</Button>
)}
{!hideLogAction && (
<Button
className={styles.IconButton}
onClick={logElement}
title="Log this component data to the console">
<ButtonIcon type="log-data" />
</Button>
)}
{!hideViewSourceAction && (
<Button
className={styles.IconButton}
disabled={!canViewSource}
onClick={viewSource}
title="View source for this element">
Expand Down
13 changes: 0 additions & 13 deletions packages/react-devtools-shared/src/devtools/views/Components/KeyValue.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
display: flex;
}

.DisabledItem {
opacity: 0.5;
}

.Name {
color: var(--color-attribute-name-not-editable);
flex: 0 0 auto;
Expand Down Expand Up @@ -40,20 +36,11 @@
flex: 1;
}

.None {
color: var(--color-dimmer);
font-style: italic;
}

.ExpandCollapseToggleSpacer {
flex: 0 0 1rem;
width: 1rem;
}

.Empty {
color: var(--color-dimmer);
}

.DeleteArrayItemButton {
padding: 0;
margin-right: 0.125rem;
Expand Down
6 changes: 0 additions & 6 deletions ...ges/react-devtools-shared/src/devtools/views/Components/NativeStyleEditor/StyleEditor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,3 @@
box-shadow: 0px 1px 3px var(--color-shadow);
}

.Empty {
color: var(--color-dimmer);
font-style: italic;
user-select: none;
padding-left: 1rem;
}
1 change: 0 additions & 1 deletion packages/react-devtools-shared/src/devtools/views/Components/NewArrayValue.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
color: var(--color-text-invalid) !important;
}

.Input:focus,
.Invalid:focus {
background-color: var(--color-button-background-focus);
}
5 changes: 1 addition & 4 deletions packages/react-devtools-shared/src/devtools/views/Components/OwnersStack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,7 @@ export default function OwnerStack(): React.Node {
))}
</div>
<div className={styles.VRule} />
<Button
className={styles.IconButton}
onClick={() => selectOwner(null)}
title="Back to tree view">
<Button onClick={() => selectOwner(null)} title="Back to tree view">
<ButtonIcon type="close" />
</Button>
</div>
Expand Down
4 changes: 0 additions & 4 deletions packages/react-devtools-shared/src/devtools/views/Profiler/HoveredFiberInfo.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@
text-overflow: ellipsis;
}

.Label {
font-weight: bold;
}

.CurrentCommit {
margin: 0.25rem 0;
display: block;
Expand Down
4 changes: 0 additions & 4 deletions packages/react-devtools-shared/src/devtools/views/Profiler/SidebarSelectedFiberInfo.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@
overflow-y: auto;
}

.WhatChanged {
margin-bottom: 1rem;
}

.Component {
flex: 1;
color: var(--color-component-name);
Expand Down
1 change: 0 additions & 1 deletion packages/react-devtools-shared/src/devtools/views/Profiler/SidebarSelectedFiberInfo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ export default function SidebarSelectedFiberInfo(_: Props): React.Node {
</div>

<Button
className={styles.IconButton}
onClick={() => selectFiber(null, null)}
title="Back to commit view">
<ButtonIcon type="close" />
Expand Down
6 changes: 1 addition & 5 deletions packages/react-devtools-shared/src/devtools/views/SearchInput.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,11 @@
white-space: pre;
}

.LeftVRule,
.RightVRule {
.LeftVRule{
height: 20px;
width: 1px;
background-color: var(--color-border);
}
.LeftVRule {
margin: 0 0.25rem 0 0.5rem;
}
.RightVRule {
margin: 0 0.5rem 0 0.25rem;
}
3 changes: 0 additions & 3 deletions packages/react-devtools-shared/src/devtools/views/SearchInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ export default function SearchInput({
<div className={styles.LeftVRule} />
<Button
data-testname={testName ? `${testName}-PreviousButton` : undefined}
className={styles.IconButton}
disabled={!searchText}
onClick={goToPreviousResult}
title={
Expand All @@ -117,7 +116,6 @@ export default function SearchInput({
</Button>
<Button
data-testname={testName ? `${testName}-NextButton` : undefined}
className={styles.IconButton}
disabled={!searchText}
onClick={goToNextResult}
title={
Expand All @@ -129,7 +127,6 @@ export default function SearchInput({
</Button>
<Button
data-testname={testName ? `${testName}-ResetButton` : undefined}
className={styles.IconButton}
disabled={!searchText}
onClick={resetSearch}
title="Reset search">
Expand Down
6 changes: 0 additions & 6 deletions packages/react-devtools-shared/src/devtools/views/Toggle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,3 @@
color: var(--color-button-disabled);
cursor: default;
}

.Input {
width: 0;
margin: 0;
opacity: 0;
}
4 changes: 0 additions & 4 deletions packages/react-devtools-shared/src/devtools/views/UnsupportedBridgeProtocolDialog.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@
margin-bottom: 0.5rem;
}

.ReleaseNotesLink {
color: var(--color-button-active);
}

.Version {
color: var(--color-bridge-version-number);
font-weight: bold;
Expand Down
6 changes: 0 additions & 6 deletions packages/react-devtools-shared/src/devtools/views/UnsupportedVersionDialog.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
align-items: center;
}

.Column {
display: flex;
flex-direction: column;
align-items: center;
}

.Title {
font-size: var(--font-size-sans-large);
margin-bottom: 0.5rem;
Expand Down
1 change: 0 additions & 1 deletion packages/react-devtools-timeline/src/EventTooltip.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
margin-right: 0.25rem;
}

.InfoText,
.WarningText {
color: var(--color-warning-text-color);
}
Expand Down
28 changes: 0 additions & 28 deletions packages/react-devtools-timeline/src/Timeline.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
justify-content: center;
}

.Paragraph {
text-align: center;
}

.ErrorMessage {
margin: 0.5rem 0;
Expand All @@ -35,28 +32,3 @@
font-size: var(--font-size-sans-large);
margin-bottom: 0.5rem;
}

.WelcomeInstructionsList {
}

.WelcomeInstructionsListItem {
display: flex;
align-items: center;
line-height: 1.5rem;
counter-increment: li;
}

.WelcomeInstructionsListItem::before {
content: counter(li);
margin-right: 0.5rem;
}

.WelcomeInstructionsListItemLink {
color: var(--color-link);
margin-left: 0.25rem;
margin-right: 0.25rem;
}

.ImportButtonLabel {
margin-left: 0.25rem;
}