Fix failing tests in latest 16.x and 18.x Node versions #25378
Conversation
| await act(async () => { | ||
| await sleep(50); | ||
| }); | ||
| })(); |
There was a problem hiding this comment.
This led to an unhandled promise rejection and therefore uncaught exception in latest Node 16.x and 18.x. Jest did not considerd this test failed and instead exited. Though it seems to me that it should? /cc @SimenB
New code results in no unhandled promise reject while still ensuring these act calls are interleaved.
There was a problem hiding this comment.
we should definitely pick up unhandled rejections - could you open up an issue so we at least track it?
There was a problem hiding this comment.
@SimenB jestjs/jest#9210 seems like it's tracking the same issue
There was a problem hiding this comment.
The test (before this PR) passes using jest-circus fwiw. So seems to be a jasmine problem
|
Comparing: 7b25b96...0244832 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
Thank you for debugging! |
Summary
Fixes full test matrix when using latest Node versions.
Unblocks #25374
#25348 is still blocked: https://app.circleci.com/pipelines/github/facebook/react/32861/workflows/e0e04ca7-b376-44dc-8fa3-0ccf76b64035/jobs/554401
How did you test this change?