Skip to content

fix: use define property to overwrite console, close #19099 #19123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2020
Merged

fix: use define property to overwrite console, close #19099 #19123

merged 2 commits into from
Jun 23, 2020

Conversation

Jack-Works
Copy link
Contributor

@Jack-Works Jack-Works commented Jun 12, 2020 •
edited
Loading

Summary

This PR fixes #19099. React crashes in the content script (Web extension) in Firefox.

Test Plan

  • validate if React no longer crashes in content script in Firefox.

@Jack-Works Jack-Works mentioned this pull request Jun 12, 2020
Closed
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 12, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 96a0dee:

Sandbox Source
kind-kapitsa-ngupe Configuration

@sizebot
Copy link

sizebot commented Jun 12, 2020 •
edited
Loading

Details of bundled changes.

Comparing: 8f05f2b...96a0dee

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-jsx-runtime.development.js +1.2% +0.8% 36.22 KB 36.66 KB 10.48 KB 10.56 KB NODE_DEV
react.development.js +0.4% +0.4% 107.71 KB 108.16 KB 26.27 KB 26.39 KB UMD_DEV
react-jsx-runtime.production.min.js 🔺+2.6% 🔺+2.0% 946 B 971 B 594 B 606 B NODE_PROD
React-dev.js +0.6% +0.6% 72.01 KB 72.44 KB 19.07 KB 19.18 KB RN_FB_DEV
React-prod.js 0.0% -0.0% 13.82 KB 13.82 KB 3.92 KB 3.92 KB RN_FB_PROD
React-profiling.js 0.0% -0.0% 13.82 KB 13.82 KB 3.92 KB 3.92 KB RN_FB_PROFILING
react-jsx-dev-runtime.development.js +1.2% +0.8% 35.64 KB 36.08 KB 10.3 KB 10.39 KB NODE_DEV
react-jsx-dev-runtime.production.min.js 🔺+5.7% 🔺+2.2% 440 B 465 B 314 B 321 B NODE_PROD
react-jsx-dev-runtime.profiling.min.js +5.7% +2.6% 439 B 464 B 312 B 320 B NODE_PROFILING
JSXDEVRuntime-dev.js +1.1% +0.9% 38.46 KB 38.89 KB 10.79 KB 10.89 KB FB_WWW_DEV
react.production.min.js 0.0% -0.0% 11.38 KB 11.38 KB 4.54 KB 4.54 KB UMD_PROD
react-jsx-runtime.profiling.min.js +2.6% +2.0% 945 B 970 B 594 B 606 B NODE_PROFILING
react.profiling.min.js 0.0% -0.0% 14.89 KB 14.89 KB 5.63 KB 5.62 KB UMD_PROFILING
react.development.js +0.6% +0.6% 69.25 KB 69.66 KB 18.65 KB 18.76 KB NODE_DEV
react.production.min.js 0.0% -0.0% 6.32 KB 6.32 KB 2.62 KB 2.62 KB NODE_PROD
JSXDEVRuntime-dev.js +1.1% +0.8% 37.1 KB 37.53 KB 10.48 KB 10.56 KB RN_FB_DEV
React-dev.js +0.4% +0.5% 98.08 KB 98.51 KB 23.82 KB 23.93 KB FB_WWW_DEV
React-prod.js 0.0% -0.0% 17.78 KB 17.78 KB 4.63 KB 4.63 KB FB_WWW_PROD
React-profiling.js 0.0% -0.0% 17.78 KB 17.78 KB 4.63 KB 4.63 KB FB_WWW_PROFILING
JSXRuntime-dev.js +1.1% +0.7% 37.69 KB 38.11 KB 10.66 KB 10.74 KB RN_FB_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 892.7 KB 893.11 KB 204.27 KB 204.34 KB NODE_DEV
ReactDOMForked-prod.js 0.0% -0.0% 406.82 KB 406.82 KB 75.24 KB 75.23 KB FB_WWW_PROD
react-dom-server.node.development.js +0.3% +0.2% 136.73 KB 137.13 KB 36.37 KB 36.46 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 122.3 KB 122.3 KB 39.03 KB 39.03 KB NODE_PROD
ReactDOMForked-profiling.js 0.0% -0.0% 417.42 KB 417.42 KB 77.01 KB 77.01 KB FB_WWW_PROFILING
react-dom-server.browser.development.js +0.3% +0.2% 142.78 KB 143.24 KB 36.58 KB 36.67 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.22 KB 20.22 KB 7.59 KB 7.58 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 13.17 KB 13.17 KB 4.89 KB 4.89 KB UMD_PROD
ReactDOMTesting-dev.js 0.0% 0.0% 978.84 KB 979.26 KB 219.84 KB 219.94 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 70.08 KB 70.08 KB 19.59 KB 19.59 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 13.05 KB 13.05 KB 4.8 KB 4.8 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 938.22 KB 938.67 KB 206.91 KB 206.99 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 122.16 KB 122.16 KB 39.92 KB 39.92 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 126.07 KB 126.07 KB 41.09 KB 41.09 KB UMD_PROFILING
ReactDOMForked-dev.js 0.0% 0.0% 998 KB 998.42 KB 222.95 KB 223.02 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% -0.0% 126.38 KB 126.38 KB 40.25 KB 40.25 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.88 KB 19.88 KB 7.44 KB 7.44 KB UMD_PROD
ReactDOM-dev.js 0.0% 0.0% 999.14 KB 999.57 KB 223.06 KB 223.14 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% -0.0% 407.01 KB 407.01 KB 75.25 KB 75.25 KB FB_WWW_PROD
react-dom-server.browser.development.js +0.3% +0.2% 135.46 KB 135.86 KB 36.12 KB 36.21 KB NODE_DEV
ReactDOM-profiling.js 0.0% -0.0% 417.61 KB 417.61 KB 77.03 KB 77.03 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.8 KB 19.8 KB 7.43 KB 7.43 KB NODE_PROD
ReactDOMServer-dev.js +0.3% +0.3% 146.53 KB 146.96 KB 37.26 KB 37.38 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 47.44 KB 47.44 KB 11.11 KB 11.11 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 75.25 KB 75.25 KB 20.09 KB 20.09 KB UMD_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% +0.1% 663.74 KB 664.19 KB 141.11 KB 141.21 KB UMD_DEV
react-art.development.js +0.1% +0.1% 566.27 KB 566.67 KB 123.35 KB 123.42 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 74.42 KB 74.42 KB 23.03 KB 23.02 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 620.29 KB 620.71 KB 132.04 KB 132.13 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.1% 0.0% 602.27 KB 602.72 KB 126.45 KB 126.51 KB UMD_DEV
react-test-renderer.development.js +0.1% 0.0% 573.83 KB 574.23 KB 124.99 KB 125.05 KB NODE_DEV
ReactTestRenderer-dev.js +0.1% +0.1% 597.1 KB 597.53 KB 127.86 KB 127.95 KB FB_WWW_DEV
ReactTestRenderer-dev.js +0.1% +0.1% 590.16 KB 590.59 KB 127.58 KB 127.67 KB RN_FB_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 39.16 KB 39.16 KB 9.57 KB 9.57 KB UMD_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.1% +0.1% 621.8 KB 622.21 KB 133.02 KB 133.09 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% -0.0% 16.68 KB 16.68 KB 4.98 KB 4.98 KB NODE_DEV
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.8 KB 2.8 KB 1.15 KB 1.15 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

React: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 96a0dee

@sizebot
Copy link

sizebot commented Jun 12, 2020 •
edited
Loading

Details of bundled changes.

Comparing: 8f05f2b...96a0dee

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-jsx-runtime.development.js +1.2% +0.8% 36.23 KB 36.67 KB 10.49 KB 10.57 KB NODE_DEV
react.development.js +0.4% +0.4% 111.74 KB 112.19 KB 27.04 KB 27.15 KB UMD_DEV
react-jsx-runtime.production.min.js 🔺+2.6% 🔺+2.0% 959 B 984 B 602 B 614 B NODE_PROD
react-unstable-cache.development.js 0.0% -0.2% 1.05 KB 1.05 KB 588 B 587 B NODE_DEV
React-dev.js +0.6% +0.5% 76.02 KB 76.45 KB 19.8 KB 19.91 KB RN_FB_DEV
react-unstable-cache.production.min.js 0.0% -0.2% 867 B 867 B 563 B 562 B NODE_PROD
React-prod.js 0.0% 0.0% 15.8 KB 15.8 KB 4.38 KB 4.39 KB RN_FB_PROD
react-unstable-cache.profiling.min.js 0.0% -0.2% 866 B 866 B 562 B 561 B NODE_PROFILING
React-profiling.js 0.0% 0.0% 15.8 KB 15.8 KB 4.38 KB 4.39 KB RN_FB_PROFILING
react-jsx-dev-runtime.development.js +1.2% +0.8% 35.65 KB 36.09 KB 10.31 KB 10.39 KB NODE_DEV
react-jsx-dev-runtime.production.min.js 🔺+5.5% 🔺+3.1% 453 B 478 B 320 B 330 B NODE_PROD
react-jsx-dev-runtime.profiling.min.js +5.5% +3.1% 452 B 477 B 319 B 329 B NODE_PROFILING
JSXDEVRuntime-dev.js +1.1% +0.9% 38.46 KB 38.89 KB 10.79 KB 10.89 KB FB_WWW_DEV
react.production.min.js 0.0% -0.0% 12.49 KB 12.49 KB 4.88 KB 4.88 KB UMD_PROD
react-jsx-runtime.profiling.min.js +2.6% +1.8% 958 B 983 B 602 B 613 B NODE_PROFILING
react.development.js +0.6% +0.6% 73.09 KB 73.5 KB 19.37 KB 19.49 KB NODE_DEV
react.production.min.js 0.0% -0.0% 7.5 KB 7.5 KB 2.96 KB 2.96 KB NODE_PROD
JSXDEVRuntime-dev.js +1.1% +0.8% 37.1 KB 37.53 KB 10.48 KB 10.56 KB RN_FB_DEV
React-dev.js +0.4% +0.4% 97.09 KB 97.52 KB 23.63 KB 23.73 KB FB_WWW_DEV
React-prod.js 0.0% -0.0% 17.64 KB 17.64 KB 4.58 KB 4.58 KB FB_WWW_PROD
React-profiling.js 0.0% -0.0% 17.64 KB 17.64 KB 4.58 KB 4.58 KB FB_WWW_PROFILING
JSXRuntime-dev.js +1.1% +0.7% 37.69 KB 38.11 KB 10.66 KB 10.74 KB RN_FB_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 923.13 KB 923.54 KB 209.84 KB 209.92 KB NODE_DEV
ReactDOMForked-prod.js 0.0% -0.0% 395.63 KB 395.63 KB 73.41 KB 73.4 KB FB_WWW_PROD
react-dom-server.node.development.js +0.3% +0.2% 138.24 KB 138.64 KB 36.58 KB 36.67 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 126.77 KB 126.77 KB 40.33 KB 40.33 KB NODE_PROD
ReactDOMForked-profiling.js 0.0% -0.0% 406.17 KB 406.17 KB 75.17 KB 75.16 KB FB_WWW_PROFILING
react-dom-server.browser.development.js +0.3% +0.2% 144.37 KB 144.82 KB 36.78 KB 36.87 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.68 KB 20.68 KB 7.66 KB 7.66 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 13.18 KB 13.18 KB 4.9 KB 4.9 KB UMD_PROD
ReactDOMTesting-dev.js 0.0% 0.0% 953.05 KB 953.47 KB 214.2 KB 214.28 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 70.09 KB 70.09 KB 19.6 KB 19.6 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% -0.0% 394.89 KB 394.89 KB 74.51 KB 74.51 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 13.06 KB 13.06 KB 4.81 KB 4.8 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 5.36 KB 5.36 KB 1.8 KB 1.8 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 706 B 705 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.87 KB 4.87 KB 1.7 KB 1.7 KB NODE_DEV
react-dom.development.js 0.0% 0.0% 970.01 KB 970.46 KB 212.6 KB 212.67 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.01 KB 1.01 KB 617 B 615 B NODE_PROD
react-dom.production.min.js 0.0% -0.0% 126.55 KB 126.55 KB 41.2 KB 41.2 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 130.51 KB 130.51 KB 42.38 KB 42.38 KB UMD_PROFILING
ReactDOMForked-dev.js 0.0% 0.0% 972.45 KB 972.88 KB 217.13 KB 217.21 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% -0.0% 130.9 KB 130.9 KB 41.51 KB 41.51 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.34 KB 20.34 KB 7.52 KB 7.52 KB UMD_PROD
ReactDOM-dev.js 0.0% 0.0% 973.59 KB 974.02 KB 217.24 KB 217.32 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% -0.0% 395.83 KB 395.83 KB 73.42 KB 73.42 KB FB_WWW_PROD
react-dom-server.browser.development.js +0.3% +0.2% 136.97 KB 137.37 KB 36.33 KB 36.42 KB NODE_DEV
ReactDOM-profiling.js 0.0% -0.0% 406.36 KB 406.36 KB 75.18 KB 75.18 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.26 KB 20.26 KB 7.51 KB 7.51 KB NODE_PROD
ReactDOMServer-dev.js +0.3% +0.3% 142.5 KB 142.93 KB 36.26 KB 36.38 KB FB_WWW_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js +0.1% +0.1% 682.71 KB 683.13 KB 147.51 KB 147.61 KB RN_FB_DEV
ReactFabric-dev.js +0.1% +0.1% 663.43 KB 663.85 KB 142.92 KB 143 KB RN_FB_DEV
ReactNativeRenderer-dev.js 0.0% -0.0% 678.25 KB 678.25 KB 146.84 KB 146.84 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% -0.0% 265.59 KB 265.59 KB 46.98 KB 46.98 KB RN_FB_PROD
ReactNativeRenderer-prod.js 0.0% -0.0% 271.91 KB 271.91 KB 48.26 KB 48.26 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% -0.0% 277.12 KB 277.12 KB 49.2 KB 49.2 KB RN_FB_PROFILING
ReactNativeRenderer-profiling.js 0.0% -0.0% 283.42 KB 283.42 KB 50.46 KB 50.46 KB RN_OSS_PROFILING
ReactNativeRenderer-prod.js 0.0% -0.0% 271.87 KB 271.87 KB 48.25 KB 48.25 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% -0.0% 283.37 KB 283.37 KB 50.44 KB 50.43 KB RN_FB_PROFILING
ReactFabric-prod.js 0.0% -0.0% 265.62 KB 265.62 KB 47 KB 46.99 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% -0.0% 277.16 KB 277.16 KB 49.22 KB 49.21 KB RN_OSS_PROFILING

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% +0.1% 685.91 KB 686.36 KB 145.19 KB 145.29 KB UMD_DEV
react-art.development.js +0.1% +0.1% 587.52 KB 587.93 KB 127.4 KB 127.47 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 77.31 KB 77.31 KB 23.89 KB 23.89 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 610.27 KB 610.7 KB 130 KB 130.1 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 12.74 KB 12.74 KB 3.97 KB 3.97 KB UMD_PROD
react-test-renderer.development.js +0.1% +0.1% 602.3 KB 602.75 KB 126.46 KB 126.53 KB UMD_DEV
react-test-renderer.production.min.js 0.0% 0.0% 76.6 KB 76.6 KB 23.97 KB 23.97 KB UMD_PROD
react-test-renderer.development.js +0.1% 0.0% 573.85 KB 574.26 KB 125.01 KB 125.06 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 76.42 KB 76.42 KB 23.67 KB 23.67 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% +0.1% 597.12 KB 597.54 KB 127.86 KB 127.96 KB FB_WWW_DEV
ReactTestRenderer-dev.js +0.1% +0.1% 590.18 KB 590.6 KB 127.59 KB 127.67 KB RN_FB_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 39.17 KB 39.17 KB 9.58 KB 9.58 KB UMD_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.1% +0.1% 645.42 KB 645.82 KB 137.53 KB 137.6 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% -0.0% 16.7 KB 16.7 KB 4.98 KB 4.98 KB NODE_DEV
react-reconciler.production.min.js 0.0% -0.0% 87.09 KB 87.09 KB 26.63 KB 26.63 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.81 KB 2.81 KB 1.16 KB 1.16 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

React: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 96a0dee

@threepointone
Copy link
Contributor

@Jack-Works could you please add a description and explain how you tested this?

cc @bvaughn, this seems reasonable

@Jack-Works
Copy link
Contributor Author

I run React in the content script (Web Extension) in the Firefox

@threepointone
Copy link
Contributor

Sorry if I wasn't clear, please add a summary of what this PR does and what it fixes, and how you tested it, in the first post of this this PR (up there, where it says "Summary" and "Test Plan"). Thanks!

@Jack-Works
Copy link
Contributor Author

Ok, I'll do it later!

@bvaughn bvaughn self-requested a review June 16, 2020 12:23
@bvaughn bvaughn self-assigned this Jun 16, 2020
@bvaughn bvaughn merged commit 5b98656 into facebook:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bvaughn bvaughn bvaughn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@bvaughn bvaughn

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: TypeError: "log" is read-only.
5 participants
@Jack-Works @sizebot @threepointone @bvaughn @facebook-github-bot