React Events: consolidate logic for Press event component #15451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
approved these changes
Apr 19, 2019
|
Added a link to an interactive demo running this patch. Will start doing this for most PRs that can benefit from reviewers checking interactions for themselves. |
necolas
force-pushed
the
react-events/press-consolidation
branch
from
6124563 to
a6c3bc7
Compare
Details of bundled changes.Comparing: 5857c89...a6c3bc7 react-events
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks on #15449. Demo integrating this patch: https://fburl.com/nfye4390
Refactor of
Pressand additional regression coverage.The logic for "start", "move", "end", and "cancel" events is consolidated into a single block to reduce duplication and improve consistency of the UX across input-types. Also reduces code size.
The bailout logic for anchor tags is removed since we
preventDefaultforclickby default. We can discuss scenarios where it makes sense to limit functionality around interactions on anchor tags.The logic for ignoring emulated events is simplified and improved. Pointer events can produce emulated touch (immediately after pointer) and mouse events (delayed) which is now accounted for and tested.
Ref #15257