Skip to content

Expose extra internals in FB build of react-dom/unstable-new-scheduler #15311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2019
Merged

Expose extra internals in FB build of react-dom/unstable-new-scheduler #15311

merged 1 commit into from
Apr 3, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Apr 3, 2019

The Facebook build of React DOM uses a forked entry point that exposes additional secret internals. I didn't account for this when I added the react-dom/unstable-new-scheduler build, so the extra internals are currently missing. This commit adds them.

@acdlite
Expose extra internals in FB build of react-dom/unstable-new-scheduler
ac1f49b 
The Facebook build of React DOM uses a forked entry point that exposes
additional secret internals. I didn't account for this when I added
the react-dom/unstable-new-scheduler build, so the extra internals
are currently missing. This commit adds them.
@acdlite acdlite merged commit 6d0effa into facebook:master Apr 3, 2019
@sizebot
Copy link

sizebot commented Apr 3, 2019

Details of bundled changes.

Comparing: 3a44cce...ac1f49b

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 886.14 KB 886.14 KB 200.15 KB 200.15 KB UMD_DEV
react-dom.profiling.min.js 0.0% 0.0% 108.5 KB 108.5 KB 34.76 KB 34.76 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 880.76 KB 880.76 KB 198.58 KB 198.59 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 105.48 KB 105.48 KB 33.61 KB 33.62 KB NODE_PROD
react-dom.profiling.min.js 0.0% 0.0% 108.59 KB 108.59 KB 34.19 KB 34.19 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 906.93 KB 906.93 KB 200.48 KB 200.48 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 333.45 KB 333.45 KB 61.35 KB 61.36 KB FB_WWW_PROD
ReactDOM-profiling.js 0.0% 0.0% 340.14 KB 340.14 KB 62.75 KB 62.75 KB FB_WWW_PROFILING
react-dom-unstable-fire.development.js 0.0% 0.0% 886.46 KB 886.46 KB 200.28 KB 200.28 KB UMD_DEV
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 108.52 KB 108.52 KB 34.77 KB 34.77 KB UMD_PROFILING
react-dom-unstable-fire.development.js 0.0% 0.0% 881.08 KB 881.08 KB 198.71 KB 198.72 KB NODE_DEV
react-dom-unstable-fire.production.min.js 0.0% 0.0% 105.49 KB 105.49 KB 33.62 KB 33.62 KB NODE_PROD
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 108.61 KB 108.61 KB 34.2 KB 34.2 KB NODE_PROFILING
ReactFire-dev.js 0.0% 0.0% 906.11 KB 906.11 KB 200.46 KB 200.46 KB FB_WWW_DEV
ReactFire-profiling.js 0.0% 0.0% 328.74 KB 328.74 KB 60.42 KB 60.42 KB FB_WWW_PROFILING
react-dom-unstable-new-scheduler.development.js 0.0% 0.0% 879.34 KB 879.34 KB 198.03 KB 198.03 KB NODE_DEV
react-dom-unstable-new-scheduler.production.min.js 0.0% 0.0% 103.54 KB 103.54 KB 33.06 KB 33.06 KB NODE_PROD
react-dom-unstable-new-scheduler.profiling.min.js 0.0% 0.0% 106.85 KB 106.85 KB 34.02 KB 34.02 KB NODE_PROFILING
ReactDOMNewScheduler-dev.js +0.1% +0.1% 905.83 KB 906.96 KB 200.33 KB 200.49 KB FB_WWW_DEV
ReactDOMNewScheduler-prod.js 🔺+3.9% 🔺+4.3% 315.38 KB 327.69 KB 58.4 KB 60.92 KB FB_WWW_PROD
ReactDOMNewScheduler-profiling.js +3.8% +4.2% 321.08 KB 333.44 KB 59.48 KB 62 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% 0.0% 10.47 KB 10.47 KB 3.87 KB 3.87 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 51.92 KB 51.92 KB 14.11 KB 14.11 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.26 KB 10.26 KB 3.79 KB 3.8 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.76 KB 60.76 KB 15.85 KB 15.85 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.69 KB 10.69 KB 3.67 KB 3.67 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.43 KB 60.43 KB 15.72 KB 15.72 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.42 KB 10.42 KB 3.56 KB 3.57 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 135.49 KB 135.49 KB 35.62 KB 35.63 KB UMD_DEV
react-dom-server.browser.development.js 0.0% 0.0% 131.62 KB 131.62 KB 34.69 KB 34.69 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.17 KB 19.17 KB 7.23 KB 7.23 KB NODE_PROD
ReactDOMServer-dev.js 0.0% 0.0% 133.88 KB 133.88 KB 34.43 KB 34.43 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 46.62 KB 46.62 KB 10.71 KB 10.71 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% 0.0% 133.56 KB 133.56 KB 35.24 KB 35.24 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 20.03 KB 20.03 KB 7.53 KB 7.53 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.21 KB 1.21 KB 704 B 706 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.49 KB 3.49 KB 1.41 KB 1.41 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.05 KB 1.05 KB 635 B 637 B NODE_PROD
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 3.74 KB 3.74 KB 1.43 KB 1.43 KB NODE_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.1 KB 1.1 KB 665 B 667 B NODE_PROD

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acdlite @sizebot @gaearon @facebook-github-bot