Fix KeyboardAvoidingView not recognizing the keyboard is dismissed after it was opened on Android

[coder966]

Summary:

Fix a problem on Android where KeyboardAvoidingView does not recognize that the keyboard is dismissed after it was opened.

Root Cause:
KeyboardAvoidingView subscribes to keyboard change events (show, hide). However, it binds the wrong event handler for keyboardDidHide. This causes _updateBottomIfNecessary to wrongfully calculate state.bottom because it relies on whether this._keyboardEvent is null or not.

Changelog:

[ANDROID] [FIXED] - Fix a problem on Android where KeyboardAvoidingView does not recognize that the keyboard is dismissed after it was opened.

Test Plan:

1. Wrap your app view tree by KeyboardAvoidingView
2. Run on android
3. open keyboard
4. observe KeyboardAvoidingView behavior which is normal
5. dismiss the keyboard
6. KeyboardAvoidingView shows a gap on the bottom of the screen as "avoiding view". But this is incorrect behaviour since the keyboard is already dismissed.

[meta-cla]

Hi @coder966!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!