Skip to content

Modal "avoidKeyboard" prop #52526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lironmosh
Copy link

Summary:

Changelog

[iOS] [Added] - Modal "avoidKeyboard" prop

The problem

It seems like the default behavior is that in iOS the modal is not avoiding the keyboard, meaning that anywhere that there is a modal that can trigger the virtual keyboard, this issue can occour.

The fix

Addign support inside the "Modal" component using a new flag called "avoidKeyboard" which is implemented by conditionally wrapping the children of the modal with "KeyboardAvoidingView" with the needed attributes to cause the modal itself to avoid the keyboard to get the desired behavior.

Reviewed By: bsalex

Differential Revision: D78010672

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 10, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78010672

lironmosh pushed a commit to lironmosh/react-native that referenced this pull request Jul 11, 2025
Summary:

## Changelog
[iOS] [Added] - Modal "avoidKeyboard" prop
## The problem
It seems like the default behavior is that in iOS the modal is not avoiding the keyboard, meaning that anywhere that there is a modal that can trigger the virtual keyboard, this issue can occour.
## The fix
Addign support inside the "Modal" component using a new flag called "avoidKeyboard" which is implemented by conditionally wrapping the children of the modal with "KeyboardAvoidingView" with the needed attributes to cause the modal itself to avoid the keyboard to get the desired behavior.

Reviewed By: bsalex

Differential Revision: D78010672
Summary:
Pull Request resolved: facebook#52526

## Changelog
[iOS] [Added] - Modal "avoidKeyboard" prop
## The problem
It seems like the default behavior is that in iOS the modal is not avoiding the keyboard, meaning that anywhere that there is a modal that can trigger the virtual keyboard, this issue can occour.
## The fix
Addign support inside the "Modal" component using a new flag called "avoidKeyboard" which is implemented by conditionally wrapping the children of the modal with "KeyboardAvoidingView" with the needed attributes to cause the modal itself to avoid the keyboard to get the desired behavior.

Reviewed By: bsalex

Differential Revision: D78010672
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78010672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants