-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Implement core Network CDP events on Android #52485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71897099
Summary: Pull Request resolved: facebook#52485 Begins integrating `NetworkReporter` (jsinspector-modern) on Android, to enable the Network panel in React Native DevTools. Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack. NOTE: As with iOS, all changes are gated behind the `enableNetworkEventReporting` and `fuseboxNetworkInspectionEnabled` feature flags. **This diff** Initially integrates the `NetworkReporter` methods corresponding to the `Network.requestWillBeSent`, `Network.requestWillBeSentExtraInfo`, `Network.responseReceived`, `Network.loadingFinished` CDP events, which are sufficient for populating a minimally rendered Network request list. - Create JNI `InspectorNetworkReporter` helper class (may also become the later public API for 3P reporting into the `Network` domain). - Renames `ResponseUtil.kt` as `NetworkEventUtil.kt`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D71897099
This pull request was exported from Phabricator. Differential Revision: D71897099 |
This pull request has been merged in b18cd58. |
This pull request was successfully merged by @huntie in b18cd58 When will my fix make it into a release? | How to file a pick request? |
Summary:
Begins integrating
NetworkReporter
(jsinspector-modern) on Android, to enable the Network panel in React Native DevTools.Since the larger lift of initial setup and the C++ subsystem has been done for iOS, this will be a lighter stack of changes solely setting up necessary integration points in the Android Networking stack.
NOTE: As with iOS, all changes are gated behind the
enableNetworkEventReporting
andfuseboxNetworkInspectionEnabled
feature flags.This diff
Initially integrates the
NetworkReporter
methods corresponding to theNetwork.requestWillBeSent
,Network.requestWillBeSentExtraInfo
,Network.responseReceived
,Network.loadingFinished
CDP events, which are sufficient for populating a minimally rendered Network request list.InspectorNetworkReporter
helper class (may also become the later public API for 3P reporting into theNetwork
domain).ResponseUtil.kt
asNetworkEventUtil.kt
.Changelog: [Internal]
Differential Revision: D71897099