-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Remove deprecated POST_NOTIFICATION from PermissionsAndroid
#36936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D45054310 |
Base commit: 9e5c963 |
This pull request was exported from Phabricator. Differential Revision: D45054310 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 17, 2023
…ok#36936) Summary: Pull Request resolved: facebook#36936 I'm removing `POST_NOTIFICATION` as that's a typo as it should be `POST_NOTIFICATIONS` We had both in version 0.71 so we can remove the wrong one as it's misleading for users. Changelog: [Android] [Removed] - Remove deprecated POST_NOTIFICATION from `PermissionsAndroid` Reviewed By: sshic Differential Revision: D45054310 fbshipit-source-id: 86000e82f06a39583192fe89f399dd949517a9a5
acab49c
to
89687a7
Compare
This pull request was exported from Phabricator. Differential Revision: D45054310 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 17, 2023
…ok#36936) Summary: Pull Request resolved: facebook#36936 I'm removing `POST_NOTIFICATION` as that's a typo as it should be `POST_NOTIFICATIONS` We had both in version 0.71 so we can remove the wrong one as it's misleading for users. Changelog: [Android] [Removed] - Remove deprecated POST_NOTIFICATION from `PermissionsAndroid` Reviewed By: NickGerleman, cipolleschi, sshic Differential Revision: D45054310 fbshipit-source-id: 0733c4ff48e18c3a571e7c42d16c0b8287e7c2a8
89687a7
to
f0b3b80
Compare
…ok#36936) Summary: Pull Request resolved: facebook#36936 I'm removing `POST_NOTIFICATION` as that's a typo as it should be `POST_NOTIFICATIONS` We had both in version 0.71 so we can remove the wrong one as it's misleading for users. Changelog: [Android] [Removed] - Remove deprecated POST_NOTIFICATION from `PermissionsAndroid` Reviewed By: NickGerleman, cipolleschi, sshic Differential Revision: D45054310 fbshipit-source-id: 16ee486547acad78db859ac1a62debecf420aca3
This pull request was exported from Phabricator. Differential Revision: D45054310 |
f0b3b80
to
787662d
Compare
This pull request has been merged in deb6b38. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…ok#36936) Summary: Pull Request resolved: facebook#36936 I'm removing `POST_NOTIFICATION` as that's a typo as it should be `POST_NOTIFICATIONS` We had both in version 0.71 so we can remove the wrong one as it's misleading for users. Changelog: [Android] [Removed] - Remove deprecated POST_NOTIFICATION from `PermissionsAndroid` Reviewed By: sshic Differential Revision: D45054310 fbshipit-source-id: be733811a1ee8e7c9d6e4986c0303eed7c07c35b
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…ok#36936) Summary: Pull Request resolved: facebook#36936 I'm removing `POST_NOTIFICATION` as that's a typo as it should be `POST_NOTIFICATIONS` We had both in version 0.71 so we can remove the wrong one as it's misleading for users. Changelog: [Android] [Removed] - Remove deprecated POST_NOTIFICATION from `PermissionsAndroid` Reviewed By: sshic Differential Revision: D45054310 fbshipit-source-id: be733811a1ee8e7c9d6e4986c0303eed7c07c35b
kelset
pushed a commit
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: #36936 I'm removing `POST_NOTIFICATION` as that's a typo as it should be `POST_NOTIFICATIONS` We had both in version 0.71 so we can remove the wrong one as it's misleading for users. Changelog: [Android] [Removed] - Remove deprecated POST_NOTIFICATION from `PermissionsAndroid` Reviewed By: sshic Differential Revision: D45054310 fbshipit-source-id: be733811a1ee8e7c9d6e4986c0303eed7c07c35b
This was referenced Aug 10, 2023
This was referenced Jan 8, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm removing
POST_NOTIFICATION
as that's a typo as it should bePOST_NOTIFICATIONS
We had both in version 0.71 so we can remove the wrong one as it's misleading for users.
Changelog:
[Android] [Removed] - Remove deprecated POST_NOTIFICATION from
PermissionsAndroid
Reviewed By: sshic
Differential Revision: D45054310