Skip to content

Conversation

cortinico
Copy link
Contributor

Summary:
I'm removing POST_NOTIFICATION as that's a typo as it should be POST_NOTIFICATIONS
We had both in version 0.71 so we can remove the wrong one as it's misleading for users.

Changelog:
[Android] [Removed] - Remove deprecated POST_NOTIFICATION from PermissionsAndroid

Reviewed By: sshic

Differential Revision: D45054310

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45054310

@analysis-bot
Copy link

analysis-bot commented Apr 17, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,620,718 -69
android hermes armeabi-v7a 7,933,391 -75
android hermes x86 9,106,714 -79
android hermes x86_64 8,961,515 -80
android jsc arm64-v8a 9,186,850 +7
android jsc armeabi-v7a 8,377,137 +1
android jsc x86 9,244,446 +1
android jsc x86_64 9,502,925 +9

Base commit: 9e5c963
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45054310

cortinico added a commit to cortinico/react-native that referenced this pull request Apr 17, 2023
…ok#36936)

Summary:
Pull Request resolved: facebook#36936

I'm removing `POST_NOTIFICATION` as that's a typo as it should be `POST_NOTIFICATIONS`
We had both in version 0.71 so we can remove the wrong one as it's misleading for users.

Changelog:
[Android] [Removed] - Remove deprecated POST_NOTIFICATION from `PermissionsAndroid`

Reviewed By: sshic

Differential Revision: D45054310

fbshipit-source-id: 86000e82f06a39583192fe89f399dd949517a9a5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45054310

cortinico added a commit to cortinico/react-native that referenced this pull request Apr 17, 2023
…ok#36936)

Summary:
Pull Request resolved: facebook#36936

I'm removing `POST_NOTIFICATION` as that's a typo as it should be `POST_NOTIFICATIONS`
We had both in version 0.71 so we can remove the wrong one as it's misleading for users.

Changelog:
[Android] [Removed] - Remove deprecated POST_NOTIFICATION from `PermissionsAndroid`

Reviewed By: NickGerleman, cipolleschi, sshic

Differential Revision: D45054310

fbshipit-source-id: 0733c4ff48e18c3a571e7c42d16c0b8287e7c2a8
…ok#36936)

Summary:
Pull Request resolved: facebook#36936

I'm removing `POST_NOTIFICATION` as that's a typo as it should be `POST_NOTIFICATIONS`
We had both in version 0.71 so we can remove the wrong one as it's misleading for users.

Changelog:
[Android] [Removed] - Remove deprecated POST_NOTIFICATION from `PermissionsAndroid`

Reviewed By: NickGerleman, cipolleschi, sshic

Differential Revision: D45054310

fbshipit-source-id: 16ee486547acad78db859ac1a62debecf420aca3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45054310

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 18, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in deb6b38.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
…ok#36936)

Summary:
Pull Request resolved: facebook#36936

I'm removing `POST_NOTIFICATION` as that's a typo as it should be `POST_NOTIFICATIONS`
We had both in version 0.71 so we can remove the wrong one as it's misleading for users.

Changelog:
[Android] [Removed] - Remove deprecated POST_NOTIFICATION from `PermissionsAndroid`

Reviewed By: sshic

Differential Revision: D45054310

fbshipit-source-id: be733811a1ee8e7c9d6e4986c0303eed7c07c35b
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…ok#36936)

Summary:
Pull Request resolved: facebook#36936

I'm removing `POST_NOTIFICATION` as that's a typo as it should be `POST_NOTIFICATIONS`
We had both in version 0.71 so we can remove the wrong one as it's misleading for users.

Changelog:
[Android] [Removed] - Remove deprecated POST_NOTIFICATION from `PermissionsAndroid`

Reviewed By: sshic

Differential Revision: D45054310

fbshipit-source-id: be733811a1ee8e7c9d6e4986c0303eed7c07c35b
kelset pushed a commit that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: #36936

I'm removing `POST_NOTIFICATION` as that's a typo as it should be `POST_NOTIFICATIONS`
We had both in version 0.71 so we can remove the wrong one as it's misleading for users.

Changelog:
[Android] [Removed] - Remove deprecated POST_NOTIFICATION from `PermissionsAndroid`

Reviewed By: sshic

Differential Revision: D45054310

fbshipit-source-id: be733811a1ee8e7c9d6e4986c0303eed7c07c35b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants