Skip to content

Android: Ensure RN_FABRIC_ENABLED is defined when building with Fabric #29939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

empyrical
Copy link
Contributor

Summary

This pull request tweaks the build script for jsiruntime to ensure that RN_FABRIC_ENABLED is defined when building for Android with Fabric enabled, and using the JavascriptCore JS engine. Without it, the createWeakObject and lockWeakObject methods in JSCRuntime.cpp will throw an exception.

Changelog

[Internal] [Changed] - Android: Ensure RN_FABRIC_ENABLED is defined when building with Fabric

Test Plan

RNTester with JSC now builds and runs on Android with Fabric enabled.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Sep 13, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 653d854

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,211,189 0
android hermes armeabi-v7a 6,860,361 0
android hermes x86 7,645,825 0
android hermes x86_64 7,536,761 0
android jsc arm64-v8a 9,370,146 0
android jsc armeabi-v7a 9,011,458 0
android jsc x86 9,232,878 0
android jsc x86_64 9,810,022 0

Base commit: 653d854

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @empyrical in 300df59.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants