Android: Ensure RN_FABRIC_ENABLED is defined when building with Fabric #29939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request tweaks the build script for
jsiruntime
to ensure thatRN_FABRIC_ENABLED
is defined when building for Android with Fabric enabled, and using the JavascriptCore JS engine. Without it, thecreateWeakObject
andlockWeakObject
methods inJSCRuntime.cpp
will throw an exception.Changelog
[Internal] [Changed] - Android: Ensure RN_FABRIC_ENABLED is defined when building with Fabric
Test Plan
RNTester with JSC now builds and runs on Android with Fabric enabled.