Skip to content

fix: hide workplace suggest on Sources placeholder element #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions front_end/panels/sources/SourcesView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import * as Common from '../../core/common/common.js';
import * as Host from '../../core/host/host.js';
import * as i18n from '../../core/i18n/i18n.js';
import * as Platform from '../../core/platform/platform.js';
import * as Root from '../../core/root/root.js';
import * as SDK from '../../core/sdk/sdk.js';
import * as Bindings from '../../models/bindings/bindings.js';
import * as Persistence from '../../models/persistence/persistence.js';
Expand Down Expand Up @@ -150,16 +151,18 @@ export class SourcesView extends Common.ObjectWrapper.eventMixin<EventTypes, typ
const placeholder = document.createElement('div');
placeholder.classList.add('sources-placeholder');

const workspaceElement = placeholder.createChild('div', 'tabbed-pane-placeholder-row');
workspaceElement.classList.add('workspace');
if (Root.Runtime.Runtime.isDescriptorEnabled({experiment: undefined, condition: Root.Runtime.conditions.notSourcesHideAddFolder})) {
const workspaceElement = placeholder.createChild('div', 'tabbed-pane-placeholder-row');
workspaceElement.classList.add('workspace');

const icon = IconButton.Icon.create('sync', 'sync-icon');
workspaceElement.createChild('span', 'icon-container').appendChild(icon);
const text = workspaceElement.createChild('span');
text.textContent = UIStrings.workspaceDropInAFolderToSyncSources;
const browseButton = text.createChild('button');
browseButton.textContent = i18nString(UIStrings.selectFolder);
browseButton.addEventListener('click', this.addFileSystemClicked.bind(this));
const icon = IconButton.Icon.create('sync', 'sync-icon');
workspaceElement.createChild('span', 'icon-container').appendChild(icon);
const text = workspaceElement.createChild('span');
text.textContent = UIStrings.workspaceDropInAFolderToSyncSources;
const browseButton = text.createChild('button');
browseButton.textContent = i18nString(UIStrings.selectFolder);
browseButton.addEventListener('click', this.addFileSystemClicked.bind(this));
}

const shortcuts = [
{actionId: 'quick-open.show', description: i18nString(UIStrings.openFile)},
Expand Down
Loading