Skip to content

imp: Rename dependencies command and add docs#339

Closed
Esemesek wants to merge 1 commit intofacebook:masterfrom
Esemesek:imp/rename-cmd
Closed

imp: Rename dependencies command and add docs#339
Esemesek wants to merge 1 commit intofacebook:masterfrom
Esemesek:imp/rename-cmd

Conversation

@Esemesek
Copy link
Copy Markdown
Contributor

Summary

Renamed the dependencies command to get-dependencies and added documentation. cc @cpojer

Test plan

Running metro in command line and compiled documentation markdown.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #339 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files         172      172           
  Lines        5221     5221           
  Branches      797      797           
=======================================
  Hits         4441     4441           
  Misses        693      693           
  Partials       87       87
Impacted Files Coverage Δ
packages/metro/src/commands/dependencies.js 23.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9880af8...695baab. Read the comment docs.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 22, 2018
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Esemesek Esemesek changed the title imp: Renamve dependencies command and add docs imp: Rename dependencies command and add docs Dec 23, 2018
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cpojer
Copy link
Copy Markdown
Contributor

cpojer commented Jan 15, 2019

That's great, thank you! You should now be able to get rid of this code in the react-native-cli code: https://github.com/react-native-community/react-native-cli/blob/master/packages/local-cli/dependencies/dependencies.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants