feat: allow reuse of ReactRefresh instance#1513
Closed
jbroma wants to merge 4 commits intofacebook:mainfrom
Closed
feat: allow reuse of ReactRefresh instance#1513jbroma wants to merge 4 commits intofacebook:mainfrom
ReactRefresh instance#1513jbroma wants to merge 4 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Contributor
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #1480
This PR enables reusing ReactRefresh instance across multiple module systems (like in MF for Metro). To achieve this following changes were made:
__METRO_GLOBAL_PREFIX__to moduleId inRefreshRuntime.register()calls__METRO_GLOBAL_PREFIX__to moduleIdregisterExportsForReactRefresh()callsglobal[global.__METRO_GLOBAL_PREFIX__ + '__ReactRefresh']inrequireRefreshimplementation__METRO_GLOBAL_PREFIX__andglobal.__METRO_GLOBAL_PREFIX__differ from each other when multiple module systems are used - in context of Module Federation, the first one would refer to the local prefix defined at the top of the bundle, while the other always refers to the one coming from the HostChangelog: [Feature] Allow reuse of React Refresh instance across multiple module systems
Test plan
TBD