Destructuring requires#298
Merged
davidaurelio merged 3 commits intofacebook:masterfrom Jul 24, 2018
mjesun:destructuring-requires
Merged
Destructuring requires#298davidaurelio merged 3 commits intofacebook:masterfrom mjesun:destructuring-requires
davidaurelio merged 3 commits intofacebook:masterfrom
mjesun:destructuring-requires
Conversation
| CallExpression: function(path, state) { | ||
| var node = path.node; | ||
| if (declarator) { | ||
| declaratorPath.scope.crawl(); |
Contributor
There was a problem hiding this comment.
The only thing that I don’t understand is why you have to crawl here, and not …
Contributor
Author
There was a problem hiding this comment.
We need to crawl because another plugin might have changed the scope already; for instance, the import / export Babel plugin. We need to have accurate variable binding, counting and referencing for the plugin to work.
| // And the associated binding in the scope. | ||
| path.scope.removeBinding(varName); | ||
| binding.referencePaths.forEach(ref => ref.replaceWith(init)); | ||
| declaratorPath.remove(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the inlining of expressions like
var x = require('foo').x, which can come from a) animport {x} from 'foo', b)const {x} = require('foo')or c)const foo = require('foo'); const x = foo.x. This will enable further optimizations when detecting deadrequires.I simplified the plugin by making use of other Babel utilities, so that we don't have to manually track variables and scopes, and we equally treat all inlinable expressions. Also fixed a bug where
var foo = require('foo'), bar = require('bar')was not properly getting inlined.Added tests to ensure that new cases are covered, made sure all existing ones still pass.