perf(core): optimize broken links checker#9778
Merged
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 986 kB ℹ️ View Unchanged
|
7 tasks
1 task
slorber
added a commit
that referenced
this pull request
Jan 26, 2024
7 tasks
This was referenced May 19, 2024
This was referenced Jun 27, 2024
This was referenced Jul 17, 2024
This was referenced Jul 21, 2024
This was referenced Jul 21, 2024
This was referenced Aug 4, 2024
This was referenced Aug 12, 2024
This was referenced Aug 15, 2024
This was referenced Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #9754
The new logic added for the broken anchor link checker made the algorithm slow for large sites with many routes and links.
This PR optimizes the algo:
matchRoutes(routes,pathname)callsTest Plan
CI + unit tests
Considering this site/commit: harness/developer-hub@d5d1311
Upgrading to Docusaurus v3.1 leads the broken link checker to take 5 minutes. After this PR it only takes 1 second.
Another site reporting significant build time improvements:
#9754 (comment)