Skip to content

fix(theme-classic): fixed wrong cursor on dropdown menu in navbar, when window is small #9398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Josh-Cena merged 4 commits into from
Nov 15, 2023
Merged

fix(theme-classic): fixed wrong cursor on dropdown menu in navbar, when window is small #9398

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7452f6c
fix: fixed wrong cursor on dropdown menu in navbar, when the window i…
Shreesh09 Oct 12, 2023
9a26214
fix: implemented the cursor fix using css and removed unnecessary links
Shreesh09 Oct 13, 2023
5934faf
chore: formatted the code
Shreesh09 Oct 16, 2023
b02d2fd
refactor: applied style to the inner `<NavbarNavLink/>` instead of th…
Shreesh09 Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...c/theme/NavbarItem/DropdownNavbarItem.tsx → ...e/NavbarItem/DropdownNavbarItem/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import type {
DesktopOrMobileNavBarItemProps,
Props,
} from '@theme/NavbarItem/DropdownNavbarItem';
import styles from './styles.module.css';

function isItemActive(
item: LinkLikeNavbarItemProps,
Expand Down Expand Up @@ -137,7 +138,7 @@ function DropdownNavbarItemMobile({

return (
<li
className={clsx('menu__list-item', {
className={clsx(styles.dropdownNavbarItemMobile, 'menu__list-item', {
Copy link
Collaborator

@Josh-Cena Josh-Cena Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it called dropdownNavbarItemMobile? It's used on desktop, right?

Copy link
Collaborator

@Josh-Cena Josh-Cena Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, this is only for mobile :)

'menu__list-item--collapsed': collapsed,
})}>
<NavbarNavLink
Expand Down
10 changes: 10 additions & 0 deletions packages/docusaurus-theme-classic/src/theme/NavbarItem/DropdownNavbarItem/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

.dropdownNavbarItemMobile {
cursor: pointer;
}