fix(core): handle single quotes inside file paths#9160
Merged
Conversation
Contributor
|
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Collaborator
Author
|
Yes, which is why I added a note to the |
|
Size Change: +473 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
slorber
requested changes
Jul 20, 2023
Collaborator
slorber
left a comment
There was a problem hiding this comment.
Looks good to me, but how can we check this works in practice? Maybe add a dogfood doc and we'll see if our site builds?
slorber
pushed a commit
to VinceCYLiao/docusaurus
that referenced
this pull request
Aug 3, 2023
This was referenced Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs