chore(create): update the facebook template with current assets#7639
chore(create): update the facebook template with current assets#7639Josh-Cena merged 1 commit intofacebook:mainfrom
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * Copyright (c) Facebook, Inc. and its affiliates. | |||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | |||
There was a problem hiding this comment.
Are we going to update the copyright headers for the rest of the codebase?
There was a problem hiding this comment.
Ya we should if we can. I did that with Flux recently
There was a problem hiding this comment.
Shouldn't you also change the Facebook Open-Source logo on that Flux site?
This PR didn't change the logo on our own site, just the template one
There was a problem hiding this comment.
We can, but I wanted to focus on the template since that's used to start new projects. Our position has been that it's not strictly necessary to go update existing projects (and it gets really noisy) but new projects should start with "Meta".
Josh-Cena
changed the title
Josh-Cena
changed the title
Josh-Cena
added
the
pr: polish
|
Are we blocked on facebookincubator/infima#260? Or can we merge this without fixing that first |
|
This is not too urgent. If Infima fixes it and the site will inherit the fix automatically, then we can merge first. |
| alt: 'Meta Open Source Logo', | ||
| // This default includes a positive & negative version, allowing for | ||
| // appropriate use depending on your site's style. | ||
| src: 'img/meta_opensource_logo_negative.png', |
There was a problem hiding this comment.
this is a svg now, will fix it
5 participants
This uses the new logo, updates copyrights, etc.
Note: It currently looks suboptimal because of facebookincubator/infima#260