Skip to content

fix(theme-classic): resolve customCss from site dir#7363

Merged
Josh-Cena merged 1 commit intomainfrom
jc/fix-custom-css
May 7, 2022
Merged

fix(theme-classic): resolve customCss from site dir#7363
Josh-Cena merged 1 commit intomainfrom
jc/fix-custom-css

Conversation

@Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Because after #6921, relative paths from plugins are resolved relative to the plugin entry point, specifying relative CSS paths no longer works. (I don't know if it worked before; never tried. It's highly possible that it didn't either.) Anyways, ./src/css/custom.css should definitely work.

Test Plan

Used a relative path in our own config.

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label May 7, 2022
@Josh-Cena Josh-Cena requested review from lex111 and slorber as code owners May 7, 2022 10:45
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 7, 2022
@netlify
Copy link

netlify bot commented May 7, 2022

[V2]

Name Link
🔨 Latest commit dc9bd0f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62764dbc278110000882fad3
😎 Deploy Preview https://deploy-preview-7363--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 7, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 64 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 83 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented May 7, 2022

Size Change: -46 B (0%)

Total Size: 811 kB

Filename Size Change
website/build/assets/js/main.********.js 615 kB -46 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.3 kB
website/build/assets/css/styles.********.css 105 kB
website/build/index.html 38.8 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit c0bd145 into main May 7, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-custom-css branch May 7, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants