fix: pass pollOptions to webpack#7180
fix: pass pollOptions to webpack#7180slorber merged 7 commits intofacebook:mainfrom JohnnyMcWeed:main
Conversation
JohnnyMcWeed
requested review from
Josh-Cena,
lex111 and
slorber
as code owners
|
Hi @JohnnyMcWeed! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7180--docusaurus-2.netlify.app/ |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
slorber
left a comment
slorber
left a comment
There was a problem hiding this comment.
Thanks
Willing to merge this after a few changes
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
|
LGTM 👍 |
4 participants
Motivation
Poll is not working in Docker, see #6722
Have you read the [Contributing Guidelines on pull requests]
No.
Test Plan
Manually tested, as there are no test cases for the start command afaik.
Related PRs
This issue might be related to it: #6722