fix(v2): Allow footer logo at attribute to be empty#3817
fix(v2): Allow footer logo at attribute to be empty#3817slorber merged 1 commit intofacebook:masterfrom aarongarciah:allow-footer-empty-alt
Conversation
|
Hi @aarongarciah! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
LGTM thanks :) don't forget to sign the CLA, will merge when the CI checks pass |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 689d200 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Motivation
Enable the footer logo to have an empty
alt=""attribute. Basically, the same that #3352 did for the navbar logo but now for the footer.See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Img#Attributes
Since the logo normally is decorative an empty alt is fine.
Fixes #3816
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
footer.logo.altoption in the Docusaurus config file to''(alt: '')yarn startand check that Docusaurus doesn't complain aboutfooter.logo.altbeing empty.