You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that the Mermaid lib is heavy and is loaded eagerly.
It is only called in useEffect, so it's fine to defer the loading.
Result
It doesn't impact all pages, but for some of them (in particular docs page not using diagrams), the amount of JS loaded can be quite significantly reduced, with one large chunk becoming much smaller.
The mermaid code has probably been split by the bundler into another chunk that will not load on docs page without diagrams, and will load later, after hydration on docs pages using diagrams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA SignedSigned Facebook CLApr: performanceThis PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slorber
added
pr: performance
Motivation
I noticed that the Mermaid lib is heavy and is loaded eagerly.
It is only called in
useEffect, so it's fine to defer the loading.Result
It doesn't impact all pages, but for some of them (in particular docs page not using diagrams), the amount of JS loaded can be quite significantly reduced, with one large chunk becoming much smaller.
The mermaid code has probably been split by the bundler into another chunk that will not load on docs page without diagrams, and will load later, after hydration on docs pages using diagrams.
Before
After
Test Plan
CI + preview
Test links
Deploy preview: https://deploy-preview-11438--docusaurus-2.netlify.app/