Skip to content

fix(theme): Add translate no to heading anchors and blog authors #11360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slorber merged 2 commits into from
Aug 4, 2025
Merged

fix(theme): Add translate no to heading anchors and blog authors #11360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6f2488
Add translate no to heading anchors
slorber Aug 4, 2025
456d614
do not translate blog author name
slorber Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/docusaurus-theme-classic/src/theme/Blog/Components/Author/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,14 @@ function AuthorTitle({title}: {title: string}) {

function AuthorName({name, as}: {name: string; as: Props['as']}) {
if (!as) {
return <span className={styles.authorName}>{name}</span>;
return (
<span className={styles.authorName} translate="no">
{name}
</span>
);
} else {
return (
<Heading as={as} className={styles.authorName}>
<Heading as={as} className={styles.authorName} translate="no">
{name}
</Heading>
);
Expand Down
3 changes: 2 additions & 1 deletion packages/docusaurus-theme-classic/src/theme/Heading/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ export default function Heading({as: As, id, ...props}: Props): ReactNode {
className="hash-link"
to={`#${id}`}
aria-label={anchorTitle}
title={anchorTitle}>
title={anchorTitle}
translate="no">
&#8203;
</Link>
</As>
Expand Down
Loading