refactor(mdx-loader): streamline typescript usage for remark plugin types#10651
Merged
slorber merged 14 commits intofacebook:mainfrom Nov 7, 2024
Merged
refactor(mdx-loader): streamline typescript usage for remark plugin types#10651slorber merged 14 commits intofacebook:mainfrom
slorber merged 14 commits intofacebook:mainfrom
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Collaborator
|
awesome 👍 thanks for the cleanup! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
I wrote a remark plugin and was not sure how i have to type the plugins correctly. So i checked with docusaurus' default plugins and saw that they are not properly typed aswell and that the structure between the remark-plugins is not really streamlined.
In my research i found the solution: type the plugins with
Plugin<PluginOptions[], Root>and let them return aTransformer<Root>(instead ofTransformeronly). Like that, TS can infer the types directly:A helpful resource was: 👉 https://unifiedjs.com/learn/recipe/narrow-node-typescript/
Test Plan
All tests still pass