refactor: move PerfLogger from core to @docusaurus/logger#10480
Merged
refactor: move PerfLogger from core to @docusaurus/logger#10480
Conversation
slorber
added
the
pr: maintenance
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ): string { | ||
| let res = ''; | ||
| values.forEach((value, idx) => { | ||
| const flag = msgs[idx]!.match(/[a-z]+=$/); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
| let res = ''; | ||
| values.forEach((value, idx) => { | ||
| const flag = msgs[idx]!.match(/[a-z]+=$/); | ||
| res += msgs[idx]!.replace(/[a-z]+=$/, ''); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
⚡️ Lighthouse report for the deploy preview of this PR
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +271 B (0%) Total Size: 11.5 MB ℹ️ View Unchanged
|
|
Hi, I am trying to upgrade my website to Docusaurus V3, after update to v3.7. The following error occurs
Then I add the config, async_hooks: false. Another similar issue occurs After checking the code, I found this PR has something related to my issue. Currently I do not have a better solution but can only stay at 3.5.2. Do you have other suggestion? |
Collaborator
Author
|
I doubt this PR is the problem, it works fine for many others It's not possible to help without a repro and your env. It could be a Node.js bug for example |
|
Thanks for the response. Currently I fixed the issue by manually add a mock file src/mocks/async_hooks.js, during development. In production, I removed the use of logger and above. |
Collaborator
Author
|
Can't help without a repro If you can't create a repro, then it's likely something special on your site that breaks things This AsyncLocalStorage feature has been stable in Node for a long time already:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a useful tool that I'd like to use in other places of Docusaurus and it looks cleaner to expose it as
@docusaurus/loggerAPI rather than@docusaurus/coreTest Plan
CI
Test links
https://deploy-preview-10480--docusaurus-2.netlify.app/