Merged
Conversation
slorber
added
the
pr: maintenance
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +381 B (0%) Total Size: 11.6 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Before migrating to Webpack 5, we used
null-loaderto ignore CSS files on the server.Technically
null-loaderis deprecated as Webpack 5 recommends usingresolve.alias.pkgName = falseto ignore a dependency, our migrated code did not "ignore" the CSS files on the server like before. Unfortunately, I don't see how we could useresolve.aliasto express what we want: we want to process.module.cssfiles on the server (so that we inject astylesobject into JS files, but ignore regular CSS imports (which we don't do anymore after the Webpack 5 upgrade).Restoring
null-loaderpermits restoring the former (Docusaurus Webpack 4) behavior and ignores regular CSS on the server to only consider CSS modules.It shouldn't change behavior because technically we don't emit CSS files on the server.
At best it has marginal performance benefits but the main reason for me to do this is mostly to be explicit. The previously present CSS loaders confused me and I was wondering why we would need them. In reality: we don't.
Test Plan
CI + preview
Test links
https://deploy-preview-10448--docusaurus-2.netlify.app/