fix(blog): authors count incorrectly rendered#10431
Merged
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +917 B (+0.01%) Total Size: 11.6 MB
ℹ️ View Unchanged
|
slorber
requested changes
Aug 20, 2024
Collaborator
slorber
left a comment
slorber
left a comment
There was a problem hiding this comment.
LGTM but you need to run a yarn command to update the translations, cf the CI test failure logs and GitHub check annotations
packages/docusaurus-theme-classic/src/theme/Blog/Pages/BlogAuthorsPostsPage/index.tsx
Outdated
Show resolved
Hide resolved
slorber
requested changes
Aug 21, 2024
packages/docusaurus-theme-common/src/translations/blogTranslations.tsx
Outdated
Show resolved
Hide resolved
| "theme.blog.archive.description___DESCRIPTION": "The page & hero description of the blog archive page", | ||
| "theme.blog.archive.title": "Archive", | ||
| "theme.blog.archive.title___DESCRIPTION": "The page & hero title of the blog archive page", | ||
| "theme.blog.author.noPosts": "This author has not written any posts yet.", |
Collaborator
There was a problem hiding this comment.
I suspect you didn't run the command the CI / tests tells you to run, this is not the expected result from running it.
What did you run?
Contributor
Author
There was a problem hiding this comment.
yarn jest, what am I supposed to run ?
Collaborator
There was a problem hiding this comment.
The tests are now passing, but you didn't read the message that the previously failing tests printed:
Errors thrown in packages/docusaurus-theme-translations/locales/tests/locales.test.ts
Summary of all failing tests
FAIL packages/docusaurus-theme-translations/locales/tests/locales.test.ts
● theme translations › has base messages files contain EXACTLY all the translations extracted from the theme. Please run "yarn workspace @docusaurus/theme-translations update" to keep base messages files up-to-date
I can see this because your extracted message has no description, and it only modified the base locale, not all the other localized files.
You are not supposed to enter that message manually in theme translations: it's the CLI command that it supposed to do so
I added the missing translations here:
d7f0fe6
We add the message everywhere so that translators just have to see what is untranslated in their local file, without having to compare it to the English file
Collaborator
|
BTW I've been meaning to enable type-aware linting in this repo, so we could catch this type of errors, but first we need to get ts-eslint up to date. |
Josh-Cena
changed the title
edwin-shdw
reviewed
Aug 22, 2024
packages/docusaurus-theme-classic/src/theme/Blog/Components/Author/index.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #10427
Test Plan
Preview
Test links
Deploy preview: https://deploy-preview-10431--docusaurus-2.netlify.app/tests/blog/authors