Skip to content

refactor: fix i18n bug in node v22#10129

Merged
slorber merged 1 commit intomainfrom
slorber/fix-node-v22-test
May 10, 2024
Merged

refactor: fix i18n bug in node v22#10129
slorber merged 1 commit intomainfrom
slorber/fix-node-v22-test

Conversation

@slorber
Copy link
Collaborator

@slorber slorber commented May 10, 2024

Motivation

Problem noticed in #10119

Note: we are not yet using Node v22 in the CI due to a v8 bug.

Unit tests do not pass under Node v22 due to a Intl behavior change. I don't know if it's a bug or if it's due to respecting the spec more strictly.

I fix this issue here, so that I can still use Node 22 locally.

Test Plan

unit tests

@slorber slorber added the pr: ignore This PR is not meaningful enough to appear in the changelog. label May 10, 2024
@slorber slorber requested a review from Josh-Cena as a code owner May 10, 2024 13:02
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 10, 2024
@netlify
Copy link

netlify bot commented May 10, 2024

[V2]

Name Link
🔨 Latest commit 93c67db
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/663e1af94562d0000820baf4
😎 Deploy Preview https://deploy-preview-10129--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 59 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 52 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 65 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 62 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report

@github-actions
Copy link

Size Change: 0 B

Total Size: 1.71 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/codeTranslations.json 2 B
website/.docusaurus/docusaurus.config.mjs 26.9 kB
website/.docusaurus/globalData.json 107 kB
website/.docusaurus/i18n.json 930 B
website/.docusaurus/registry.js 275 kB
website/.docusaurus/routes.js 179 kB
website/.docusaurus/routesChunkNames.json 119 kB
website/.docusaurus/site-metadata.json 2.17 kB
website/build/assets/css/styles.********.css 112 kB
website/build/assets/js/main.********.js 853 kB
website/build/index.html 38.1 kB

compressed-size-action

@slorber slorber merged commit 02e38d8 into main May 10, 2024
@slorber slorber deleted the slorber/fix-node-v22-test branch May 10, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: ignore This PR is not meaningful enough to appear in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants