2.0.0-beta.22 breaks cross-repo deploy to GitHub Pages

[yechs]

Have you read the Contributing Guidelines on issues?

• I have read the Contributing Guidelines on issues.

Prerequisites

• I'm using the latest version of Docusaurus.
• I have tried the npm run clear or yarn clear command.
• I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
• I have tried creating a repro with https://new.docusaurus.io.
• I have read the console error message carefully (if applicable).

Description

Updating to docusaurus v2.0.0-beta.22 breaks my deployment to GitHub Pages.

The relevant commandline error follows:

[INFO] `git commit -m "Deploy website - based on 6f67bb9205e05e2d37ba6368e30774c48e6db78d"` code: 0
To github.com:yechs/website.git
 ! [remote rejected] master -> master (shallow update not allowed)
error: failed to push some refs to 'github.com:yechs/website.git'
[INFO] `git push --force origin master` code: 1
[ERROR] Deployment of the build output failed.
[ERROR] Error: Running "git push" command failed. Does the GitHub user account you are using have push access to the repository?
    at runDeploy (/Users/yeshu/Coding/Personal/website/node_modules/@docusaurus/core/lib/commands/deploy.js:168:19)
    at async Command.deploy (/Users/yeshu/Coding/Personal/website/node_modules/@docusaurus/core/lib/commands/deploy.js:189:13)
error Command failed with exit code 1.

According to the command line output, it looks like a shallow update problem. However, the weird thing is, docusaurus has been doing shallow clone deployments for almost a year now and has never failed before.
Relevant PR: #5748

Logs

If you want a full log, there is one available from GitHub Actions (https://github.com/yechs/website/runs/7256462347)

And here is the successful log running yarn deploy on v2.0.0-beta.21 three days ago (https://github.com/yechs/website/runs/7204294330)

Reproduction

Just to rule out the variables of GitHub Actions or GitHub changing their behavior:

I've ran yarn deploy locally on v2.0.0-beta.22 and it failed with the same message.
I have also manually reverted back to v2.0.0-beta.21 and ran yarn deploy, which functioned perfectly normal. (Note that it is doing the same shallow clone)

Reproducible demo

https://github.com/yechs/website/

Steps to reproduce

1. Run yarn deploy
2. Observe that it fails
3. git checkout 193d6e0 to go back to docusaurus v2.0.0-beta.21
4. Run yarn to install dependencies
5. Run yarn deploy
6. Observe that it succeeds

Expected behavior

Deployment continues to function as in v2.0.0-beta.21

Actual behavior

Deployment fails. See log from GitHub Actions.

Your environment

• Public source code:
  • Source code at https://github.com/yechs/website/
  • Deployed to https://github.com/yechs/yechs.github.io/
• Public site URL:
• Docusaurus version used:
  • v2.0.0-beta.22
• Environment name and version (e.g. Chrome 89, Node.js 16.4):
• Operating system and version (e.g. Ubuntu 20.04.2 LTS):
  • Ubuntu (GitHub Actions) with Node v16
  • MacOS with Node v16.15.1
  • Arch Linux with Node v16.14.2

Self-service

• I'd be willing to fix this bug myself.

[Josh-Cena]

Looks like a bug with #7702? Could you try running 0.0.0-5163?

[yechs]

Yes deploying with 0.0.0-5163 is fine. Could be related to this issue

[yechs]

I have taken a look at the PR content. It may be possible that by copying over local .git/config, the remote origin url is also copied over.

However, I'm deploying to a different repo other than the source repo, which has a different "origin" url. This causes a problem. When coping over the git config file, the destination origin is also overwritten. Hence, git will push to a different repository and naturally fail.

[Josh-Cena]

cc @ghostsquad Any ideas?

[yechs]

In my humble opinion, it would be counter-intuitive to copy git configs during deployment.

It should be up to the CI to set up the desired git configuration environment, either via environment variables or, in the case of more advanced configs such as gpg signing key, via global configuration

[ghostsquad]

The problem is that I don't want to just deploy via CI. A local deployment should be valid as well. Let me look at the error...

[Josh-Cena]

A local deployment should be valid as well.

You can always change your deploy script in package.json.

[ghostsquad]

I can submit a pull request to add a git configuration map to the main config file that is used for this operation. It would allow arbitrary configuration to be applied after the clone operation.

[ghostsquad]

A local deployment should be valid as well.

You can always change your deploy script in package.json.

literally the only thing I need to change is some simple stuff like my email, gpg key, etc. It shouldn't be necessary to reproduce the entirety of what's already being done just to inject some git config.