Skip to content

Simplify wording in setting-up-your-editor.md #8684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2020
Merged

Simplify wording in setting-up-your-editor.md #8684

merged 1 commit into from
Apr 7, 2020

Conversation

coryhouse
Copy link
Contributor

No description provided.

@coryhouse coryhouse requested review from amyrlam and iansu as code owners March 21, 2020 12:51
gabrielbussolo
gabrielbussolo approved these changes Apr 5, 2020
View reviewed changes
Copy link

@gabrielbussolo gabrielbussolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@ianschmitz ianschmitz added this to the 3.5 milestone Apr 7, 2020
@ianschmitz ianschmitz changed the title Simplify wording Simplify wording in setting-up-your-editor.md Apr 7, 2020
@ianschmitz ianschmitz merged commit f0f4d5b into facebook:master Apr 7, 2020
@ianschmitz
Copy link
Contributor

Thanks @coryhouse!

@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
@ianschmitz ianschmitz modified the milestones: 3.5, 4.0 May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyrlam amyrlam Awaiting requested review from amyrlam

@iansu iansu Awaiting requested review from iansu

3 more reviewers

@gabrielbussolo gabrielbussolo gabrielbussolo approved these changes

@ianschmitz ianschmitz ianschmitz approved these changes

@hong4rc hong4rc hong4rc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@coryhouse @ianschmitz @gabrielbussolo @hong4rc @facebook-github-bot