Skip to content

Remove no-unexpected-multiline rule #8039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2019
Merged

Remove no-unexpected-multiline rule #8039

merged 1 commit into from
Nov 28, 2019

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Nov 27, 2019

Closes #7005

iansu
iansu commented Nov 27, 2019
View reviewed changes
CHANGELOG.md
@@ -48,14 +48,9 @@ We've removed this rule as it is not compatible with Prettier. If you rely on th
```json
{
"extends": "react-app",
"overrides": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove this rule this no longer needs to be an override.

@iansu iansu added this to the 3.3 milestone Nov 27, 2019
@iansu iansu merged commit fffc777 into facebook:master Nov 28, 2019
@iansu iansu deleted the disable-no-unexpected-multiline branch November 28, 2019 21:07
@lock lock bot locked and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

2 more reviewers

@ianschmitz ianschmitz ianschmitz approved these changes

@petetnt petetnt petetnt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

no-unexpected-multiline rule clashes with Prettier
4 participants
@iansu @ianschmitz @petetnt @facebook-github-bot