Use @typescript-eslint/no-unused-expressions to support optional chaining #8003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues with optional chaining
maxdavidson
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
ianschmitz
approved these changes
Nov 20, 2019
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eslint's
no-unused-expressionsrule doesn't support the new optional chaining syntax and yields false positives. Typescript-eslints's equivalent was recently updated to support it, so use it instead.This fix only affects TypeScript, so in order to make it work for plain JavaScript we'd have to wait for official Eslint support or perhaps add another plugin like this one.