Upgrade dotenv-expand to 4.2.0 (#3961) #3992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like we’ll want to do this against master too and cut another patch to 1.x. |
|
Good idea. Should I submit another PR for that? Any idea why those tests are failing? Seems unrelated to this. |
|
Yes, please send a PR. |
|
Failing tests look worrying. cc @bradfordlemley I had this symptom when Jest was "finding" a wrong version of |
|
Fix for the monorepo test failures: #3997. (Not related to the current PR.) |
1msoft
added a commit
to 1msoft/create-react-app
that referenced
this pull request
Feb 10, 2018
This reverts commit c263f17.
akstuhl
pushed a commit
to akstuhl/create-react-app
that referenced
this pull request
Mar 15, 2018
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
dotenv-expandto fix bug with environment variables that contain a$.Closes #3961