Skip to content

Rename Overlay to ErrorOvelay #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2017
Merged

Rename Overlay to ErrorOvelay #3051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...t-error-overlay/src/components/Overlay.js → ...or-overlay/src/components/ErrorOverlay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const overlayStyle = {
color: black,
};

class Overlay extends Component {
class ErrorOverlay extends Component {
iframeWindow: window = null;

getIframeWindow = (element: HTMLDivElement) => {
Expand Down Expand Up @@ -71,4 +71,4 @@ class Overlay extends Component {
}
}

export default Overlay;
export default ErrorOverlay;
6 changes: 3 additions & 3 deletions packages/react-error-overlay/src/containers/CompileErrorContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

/* @flow */
import React, { PureComponent } from 'react';
import Overlay from '../components/Overlay';
import ErrorOverlay from '../components/ErrorOverlay';
import Footer from '../components/Footer';
import Header from '../components/Header';
import CodeBlock from '../components/CodeBlock';
Expand All @@ -19,11 +19,11 @@ class CompileErrorContainer extends PureComponent {
render() {
const { error } = this.props;
return (
<Overlay>
<ErrorOverlay>
<Header headerText="Failed to compile" />
<CodeBlock main={true} codeHTML={generateAnsiHTML(error)} />
<Footer line1="This error occurred during the build time and cannot be dismissed." />
</Overlay>
</ErrorOverlay>
);
}
}
Expand Down
6 changes: 3 additions & 3 deletions packages/react-error-overlay/src/containers/RuntimeErrorContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

/* @flow */
import React, { PureComponent } from 'react';
import Overlay from '../components/Overlay';
import ErrorOverlay from '../components/ErrorOverlay';
import CloseButton from '../components/CloseButton';
import NavigationBar from '../components/NavigationBar';
import RuntimeError from './RuntimeError';
Expand Down Expand Up @@ -52,7 +52,7 @@ class RuntimeErrorContainer extends PureComponent {
const { errorRecords, close } = this.props;
const totalErrors = errorRecords.length;
return (
<Overlay shortcutHandler={this.shortcutHandler}>
<ErrorOverlay shortcutHandler={this.shortcutHandler}>
<CloseButton close={close} />
{totalErrors > 1 &&
<NavigationBar
Expand All @@ -69,7 +69,7 @@ class RuntimeErrorContainer extends PureComponent {
line1="This screen is visible only in development. It will not appear if the app crashes in production."
line2="Open your browser’s developer console to further inspect this error."
/>
</Overlay>
</ErrorOverlay>
);
}
}
Expand Down