Adding Code of Conduct file #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 12, 2021
Summary: While building the discrete workload distribution from its predecessors(normal and range), we created too many types with very little difference. We currently have 1. Discrete distribution - uses FastDiscrete for popularity, discrete dist for value sizes. 2. Normal distribution - uses normal dist for popularity, discrete dist for value sizes 3. Range distribution - uses normal dist for popularity, piecewise dist for value sizes. The difference between #2 and #3 was hard to grasp unless you read the code closely and made the documentation confusing. Rather now, we have support for either using piece wise or discrete value sizes based on the probability specification in the config. Reviewed By: therealgymmy Differential Revision: D25881345 fbshipit-source-id: c040b553a97729b899a6b9938fc3bf9edefb5df8
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 16, 2021
Summary:
We recently found cogwheel_cachelib_sanitizer_free_list_stress test failed periodically (T98156036).
Error log:
```
AddressSanitizer: SEGV cachelib/cachebench/runner/Runner.h:54 in facebook::cachelib::cachebench::Runner::abort()
Thread T68 created by T0 here:
#0 0xeb23232 in pthread_create (/packages/cachelib.cachebench.opt-ubsan-asan/cachebench+0xeb23232)
#1 0x7fd090412adc in __gthread_create /home/engshare/third-party2/libgcc/9.x/src/gcc-9.x/x86_64-facebook-linux/libstdc++-v3/include/x86_64-facebook-linux/bits/gthr-default.h:663:35
#2 0x7fd090412adc in std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State> >, void (*)()) /home/engshare/third-party2/libgcc/9.x/src/gcc-9.x/x86_64-facebook-linux/libstdc++-v3/src/c++11/../../../.././libstdc++-v3/src/c++11/thread.cc:135:37
#3 0x4464468 in std::thread::thread<setupTimeoutHandler()::$_1, void>(setupTimeoutHandler()::$_1&&) third-party-buck/platform009/build/libgcc/include/c++/9.x/thread:130
#4 0x4464468 in setupTimeoutHandler() cachelib/cachebench/main.cpp:88
#5 0x4464f8f in main cachelib/cachebench/main.cpp:149
#6 0x7fd0900f2d94 in __libc_start_main /home/engshare/third-party2/glibc/2.30/src/glibc-2.30/csu/../csu/libc-start.c:308:16
#7 0x4464029 in _start /home/engshare/third-party2/glibc/2.30/src/glibc-2.30/csu/../sysdeps/x86_64/start.S:120
```
The reason should be when one thread is calling `Runner::abort()` after timeout https://fburl.com/code/tpuk95xy, the other thread is executing in the middle of `Runner::run()` after line 54 but before line 55 https://fburl.com/code/7fskwd12. Line 54 set the `stressor_` to be `nullptr` and causes the failure.
To fix that, we should only abort when stressor_ is not nullptr.
Reviewed By: haowu14
Differential Revision: D30318655
fbshipit-source-id: 1974e69c5030c73d52f0517fa721bcd6599cc884
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
Summary: AdRanker ASAN canary flagged a possible UBSan violation. ## Error Failed Run: https://fburl.com/servicelab/apytosry ``` #0 0x562e3adb59bc in facebook::cachelib::objcache2::ObjectCacheSizeController<facebook::cachelib::CacheAllocator<facebook::cachelib::LruCacheTrait> >::work() buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h #1 0x562de7610f78 in facebook::cachelib::PeriodicWorker::loop() fbcode/cachelib/common/PeriodicWorker.cpp:55 #2 0x7f7632c524e4 in execute_native_thread_routine /home/engshare/third-party2/libgcc/11.x/src/gcc-11.x/x86_64-facebook-linux/libstdc++-v3/src/c++11/../../../.././libstdc++-v3/src/c++11/thread.cc:82:18 #3 0x7f7632f6ec0e in start_thread /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/nptl/pthread_create.c:434:8 #4 0x7f76330011db in clone3 /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 UndefinedBehaviorSanitizer: integer-divide-by-zero buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h:33:40 in ``` Reviewed By: jiayuebao Differential Revision: D39024188 fbshipit-source-id: 64ad644c360565e638fa3ca74616a315038382ab
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pull request was created automatically because we noticed your project was missing a Code of Conduct file.
Code of Conduct files facilitate respectful and constructive communities by establishing expected behaviors for project contributors.
This PR was crafted with love by Facebook's Open Source Team.