Potential clang-format config

[erysdren]

Would appreciate some thoughts on this. I'm not committing the clang-format'd files themselves, just the config (and the CMakeLists.txt entry). Feel free to checkout the branch and see the formatted results. I think it's a pretty good, neutral style.

[erysdren]

@fabiangreffrath what's your opinion on this? i feel like running a full clang-format would make it a lot harder to directly apply patches from other ports, but... we haven't really done that at all anyway. on the other hand i think it would definitely enhance code readability across the board, and make it easier for people to work on it without being massively confused. it would be a gigantic commit, but we'd only have to do it once.

[fabiangreffrath]

Yes, I am torn on this as well. On the one hand, the source is a pain to read and I am getting tired very quickly on it. I guess that's one of the reasons why I was so inactive lately. On the other hand, we want to make it easier for contributors to add their code and thus keep it close to the original, but - as you already stated - this only happens very rarely and it's probably easier and more motivating to work on a cleaned up code than on this mess.

I am not afraid of the sheer size of the commit. The question is, should we do it now or after the next tag/release?

[erysdren]

probably good to do it immediately after the next release, which i assume you're gonna do soon-ish. i've pretty much run out of easy fixes and patches i can do in the short time (atleast, that i know of). so i'd be happy to wait until after the next release.

i'd also appreciate any feedback you may have about the specifics of the clang-format options - i tailored it more or less to my preferences, and that should be pretty readable to everyone, but feel free to nitpick if you want to.

[fabiangreffrath]

I'd prefer to copy over the .clang-format file from Woof, to be honest, because that's the style I got used to when coding game ports.

[fabiangreffrath]

BTW, Opensuse has already packaged up a recent snapshot and even provides a short changelog:

https://build.opensuse.org/projects/openSUSE:Factory/packages/taradino/files/taradino.changes?expand=1

Apart from this, is there anything else that you'd like to show up in the changelog for the next "release"?

[erysdren]

re: changelog items

• Automatically detects level packs from other ROTT installations
• Improved documentation
• Many rendering bug fixes
• More consistent framerate
• Show the DOS text mode splash when exiting the game

[fabiangreffrath]

Alright, very good additions! We currently do not upload any artifacts when a release is tagged. Would you like to change that? I myself could live with source-only releases.

[erysdren]

i think we should probably upload the CI artifacts for a tagged release if it's not too much trouble. most people won't wanna build it from source!