Skip to content

Sync isbn-verifier with problem specifications - #531

Merged
BNAndras merged 1 commit into
exercism:mainfrom
ManasDasri:sync-isbn-verifier
Aug 10, 2026
Merged

Sync isbn-verifier with problem specifications#531
BNAndras merged 1 commit into
exercism:mainfrom
ManasDasri:sync-isbn-verifier

Conversation

@ManasDasri

@ManasDasri ManasDasri commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Adds two canonical test cases missing from the isbn-verifier suite: 'only one check digit is allowed' and 'X is not substituted by the value 10'. Verified via ./bin/test.ps1 isbn-verifier - 21/21 tests pass. No changes to Example.vb needed since the existing solution already handles both cases correctly.

Closes #453

@github-actions

Copy link
Copy Markdown

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions

Copy link
Copy Markdown

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@github-actions github-actions Bot closed this Aug 10, 2026
@github-actions

Copy link
Copy Markdown

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

@github-actions

Copy link
Copy Markdown

This is an unmaintained repository.

Cross-track maintainers - feel free to merge.

@BNAndras BNAndras reopened this Aug 10, 2026
@BNAndras BNAndras added x:module/practice-exercise Work on Practice Exercises x:action/sync Sync content with its latest version x:rep/small Small amount of reputation labels Aug 10, 2026
@BNAndras

Copy link
Copy Markdown
Member

Looks good! Thanks!

@BNAndras
BNAndras merged commit f09d55c into exercism:main Aug 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/sync Sync content with its latest version x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync isbn-verifier with problem specifications

2 participants