Skip to content

Typos + missing + sorting use - #1017

Merged
mk-mxp merged 8 commits into
exercism:mainfrom
resu-xuniL:typos-missing-sorting-use
Jul 11, 2026
Merged

Typos + missing + sorting use#1017
mk-mxp merged 8 commits into
exercism:mainfrom
resu-xuniL:typos-missing-sorting-use

Conversation

@resu-xuniL

Copy link
Copy Markdown
Contributor
  • Fixed a typo in BookStoreTest.php
  • Fixed a missing use statement in word_countTest.php
  • Harmonise the order of the use statements
  • Removed useless comments on MarkdownTest.php and its example.php
  • Add rule to sort use statement + apply

[no important files changed]

Tell me if i shall drop one or more, or all of these!

@github-actions

Copy link
Copy Markdown
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@mk-mxp
mk-mxp force-pushed the typos-missing-sorting-use branch from af69bcb to 69b67fb Compare July 11, 2026 14:18
@mk-mxp

mk-mxp commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

OK, the issue was a commit, that only added the TestDox use above the other uses, but did not remove the lower use of TestDox. That likely happened as you merged in the changes to main. It's better to rebase the branches on main:

git checkout main
git pull -p
git checkout typos-missing-sorting-use
git rebase main
git push -f

@mk-mxp
mk-mxp merged commit 117e17e into exercism:main Jul 11, 2026
13 checks passed
@resu-xuniL

resu-xuniL commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for your help

@mk-mxp mk-mxp added x:action/fix Fix an issue x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Jul 11, 2026
@resu-xuniL
resu-xuniL deleted the typos-missing-sorting-use branch July 11, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/fix Fix an issue x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants