Skip to content

Prefix 32 bit and 64 bit architectures to avoid confusion#80

Merged
kntsoriano merged 1 commit into
masterfrom
prefix-architectures
Jul 3, 2019
Merged

Prefix 32 bit and 64 bit architectures to avoid confusion#80
kntsoriano merged 1 commit into
masterfrom
prefix-architectures

Conversation

@kntsoriano

Copy link
Copy Markdown
Contributor

Closes #58.

Is this correct? Not really that much familiar with the different architectures.

@kntsoriano kntsoriano requested a review from kytrinyx July 1, 2019 02:01
@iHiD

iHiD commented Jul 1, 2019

Copy link
Copy Markdown
Member

(cc @vbuell)

@kytrinyx kytrinyx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but I would very much appreciate a signoff from @vbuell on this one!

@vbuell

vbuell commented Jul 2, 2019

Copy link
Copy Markdown

yep. the change looks fine. thanks, Karlo

@kntsoriano

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing :)

@kntsoriano kntsoriano merged commit 7fdd16d into master Jul 3, 2019
@kntsoriano kntsoriano deleted the prefix-architectures branch July 3, 2019 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prefix 32 and 64 architectures with x86 to distinguish from ARM

4 participants