Skip to content

Fix the test to match with Matrix value type#2885

Merged
andrerfcsantos merged 1 commit into
exercism:mainfrom
martinkunc:matrix-fix-test-nil-check
Nov 22, 2025
Merged

Fix the test to match with Matrix value type#2885
andrerfcsantos merged 1 commit into
exercism:mainfrom
martinkunc:matrix-fix-test-nil-check

Conversation

@martinkunc

@martinkunc martinkunc commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

It looks like the Matrix excercise was changed from reference to value type, but the test was not adjusted. Adding a fix.
Tested in place with current matrix implementation.
I think it has been discussed in forum at: https://forum.exercism.org/t/go-track-matrix-problem/3655

@github-actions

github-actions Bot commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions

github-actions Bot commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@github-actions github-actions Bot closed this Nov 2, 2025
@andrerfcsantos andrerfcsantos merged commit 1cebcbd into exercism:main Nov 22, 2025
20 checks passed
@martinkunc martinkunc deleted the matrix-fix-test-nil-check branch November 22, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants