Skip to content

fix(expenses): enforce category name in error message #2862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcaurele wants to merge 1 commit into from
Closed

fix(expenses): enforce category name in error message #2862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions exercises/concept/expenses/expenses_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ func TestCategoryExpenses(t *testing.T) {
p DaysPeriod
total float64
wantErr bool
errMsg string
}{
{
name: "returns error when no records with category found in any days period",
Expand All @@ -229,6 +230,7 @@ func TestCategoryExpenses(t *testing.T) {
},
total: 0,
wantErr: true,
errMsg: "unknown category food",
},
{
name: "returns total category expenses in the provided days period",
Expand All @@ -239,6 +241,7 @@ func TestCategoryExpenses(t *testing.T) {
},
total: 19.6,
wantErr: false,
errMsg: "",
},
{
name: "returns 0 when no category expenses found in the provided days period",
Expand All @@ -249,14 +252,15 @@ func TestCategoryExpenses(t *testing.T) {
},
total: 0,
wantErr: false,
errMsg: "",
},
}
for _, tC := range testCases {
t.Run(tC.name, func(t *testing.T) {
got, err := CategoryExpenses(testExpensesRecords, tC.p, tC.category)
if tC.wantErr && err == nil {
t.Fatalf("CategoryExpenses(%v, %s, %v)=%.2f,%v but want a non-nil error",
testExpensesRecords, tC.category, tC.p, got, err)
if tC.wantErr && (err == nil || err.Error() != tC.errMsg) {
t.Fatalf("CategoryExpenses(%v, %s, %v)=%.2f,%v but want a non-nil error with %v",
testExpensesRecords, tC.category, tC.p, got, err, tC.errMsg)
}

if !tC.wantErr && err != nil {
Expand Down