Add "counter", a write-the-test-suite exercise#168
Conversation
|
Hm. Yepp, that's still the case: Maybe we should just take the feature out. Are we being too helpful? When we added that feature we didn't have the "delete submission" feature, but now that's not an issue. |
|
We could replace it with a message saying "You're submitting a test file. If this is not what you want you can delete it in this way ...". That's still fairly helpful. |
|
Agreed. I like leaving the responsibility to the user rather than trying to be overly helpful. |
|
The I looked through this again, and the only question I have is whether we should name the test file |
|
I believe I went with |
|
The current file name is |
There was a problem hiding this comment.
Can we rename the file to example_test.go?
There was a problem hiding this comment.
Doesn't that automatically include it in the files sent to the user?
There was a problem hiding this comment.
No, anything with example in the path (not just the name of the file) will be excluded from the payload to the user.
There was a problem hiding this comment.
After trying this I remembered why it doesn't work. The example_test.go gets picked up by go test in the travis and fails since you have to explicitly set an environment variable to choose an implementation to test with.
There was a problem hiding this comment.
Ah, right. Yepp, that makes sense! Would you add a comment to that effect in the file itself? I can see myself forgetting this and going through the exact same set of questions six months from now.
|
Added explanation and rebased. |
Add "counter", a write-the-test-suite exercise
2 participants
I'm a bit worried about the exercism cli tool here. I seem to recall that it stops the user accidentally submitting the test file, but in this case the file with the "_test.go" name is the submission.