The API token outputted during verbose will now be masked by default#866
Merged
kytrinyx merged 9 commits intoexercism:masterfrom Aug 8, 2019
Jrank2013:masking_api_token
Merged
The API token outputted during verbose will now be masked by default#866kytrinyx merged 9 commits intoexercism:masterfrom Jrank2013:masking_api_token
kytrinyx merged 9 commits intoexercism:masterfrom
Jrank2013:masking_api_token
Conversation
kotp
suggested changes
Aug 2, 2019
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
kytrinyx
requested changes
Aug 3, 2019
Member
kytrinyx
left a comment
kytrinyx
left a comment
There was a problem hiding this comment.
Thank you so much for taking the time to tackle this one! This is going to be a huge improvement for support requests.
This PR contains some changes that are unrelated to the token masking. In particular, it has changes to the dependency tracking files. Would you mind removing those from the PR? I'm not opposed to updating those files, but if so I'd like to do it as its own change.
I also have a suggestion about where to put the Redact token.
Contributor
Author
|
What suggestions did you have for Redact? |
Member
|
Shoot, I wonder why that didn't get posted. I would like to avoid having a |
Contributor
Author
|
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will fix #860. The token is now masked by default and the unmask-token command will unmask it now