Skip to content

Update submit error message when submitting a directory #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nywilken merged 5 commits into from
Aug 31, 2018
Merged

Update submit error message when submitting a directory #724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7654db
Update error message for submision of directory
Aug 29, 2018
91088b8
Update test to check for helpful error
Aug 29, 2018
2c58245
Updating message format to use BinaryName
Aug 29, 2018
7c03f28
Update error message format further
Aug 30, 2018
088037a
Fix test by double escaping
Aug 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cmd/submit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,12 @@ func runSubmit(cfg config.Config, flags *pflag.FlagSet, args []string) error {

%s

Please change into the directory and provide the path to the file(s) you wish to submit

%s submit FILENAME

`
return fmt.Errorf(msg, arg)
return fmt.Errorf(msg, arg, BinaryName)
}

src, err := filepath.EvalSymlinks(arg)
Expand Down
1 change: 1 addition & 0 deletions cmd/submit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ func TestSubmitFilesAndDir(t *testing.T) {
}
err = runSubmit(cfg, pflag.NewFlagSet("fake", pflag.PanicOnError), files)
assert.Regexp(t, "submitting a directory", err.Error())
assert.Regexp(t, "Please change into the directory and provide the path to the file\\(s\\) you wish to submit", err.Error())
}

func TestSubmitFiles(t *testing.T) {
Expand Down