download: fix support for uuid flag#713
Merged
kytrinyx merged 2 commits intoexercism:masterfrom Aug 23, 2018
Merged
Conversation
kytrinyx
approved these changes
Aug 23, 2018
Member
kytrinyx
left a comment
kytrinyx
left a comment
There was a problem hiding this comment.
Shoot! I wish we had a failing test that caught this.
I'm going to merge and cut a release.
Contributor
Author
Agreed. I started looking into writing some tests this am. I’ll open a PR when ready. |
Member
|
@nywilken thanks! It was more critical to get the fix out than to wait for a test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the issue #712 where calling download with a solution UUID errors because the command is overriding the provided UUID with the string latest. This change also adds a mutual exclusive check for the uuid and exercise flag used by the download command.