Skip to content

Add more guards to the download command#642

Merged
kytrinyx merged 3 commits intomasterfrom
download-guards
Jul 14, 2018
Merged

Add more guards to the download command#642
kytrinyx merged 3 commits intomasterfrom
download-guards

Conversation

@kytrinyx
Copy link
Copy Markdown
Member

@kytrinyx kytrinyx commented Jul 14, 2018

This will give better error messages when downloading a solution without having configured the CLI for the new site.

Merging so I can cut a release.

Katrina Owen added 3 commits July 14, 2018 18:23
We need this same error message for the download command.
If you're going to download an exercise, we need to know where to download it to.
This will ask the user to re-run the configure command if the workspace isn't configured.
@kytrinyx kytrinyx merged commit 6d4396b into master Jul 14, 2018
@kytrinyx kytrinyx deleted the download-guards branch July 14, 2018 23:30
Copy link
Copy Markdown
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged before I could approve.. but looks good. Nice catch on the baseapiurl

@kytrinyx
Copy link
Copy Markdown
Member Author

Thanks @nywilken. I wasn't sure you were around and I need to get this release cut before I get on this next flight. This will slow down shortly, I promise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants