Skip to content

Fix upgrade command on some Linux systems #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tonkpils merged 2 commits into from
Feb 21, 2016
Merged

Fix upgrade command on some Linux systems #290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11c758c
Fix upgrade command for Linux systems (fixes #288)
jbaiter Feb 3, 2016
3a6b50e
Recover old version in case upgrade fails
jbaiter Feb 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cmd/release_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,25 @@ func installTgz(source *bytes.Reader, dest string) error {
return err
}

// Move the old version to a backup path that we can recover from
// in case the upgrade fails
destBackup := dest + ".bak"
if _, err := os.Stat(dest); err == nil {
os.Rename(dest, destBackup)
}

fileCopy, err := os.OpenFile(dest, installFlag, hdr.FileInfo().Mode())
if err != nil {
os.Rename(destBackup, dest)
return err
}
defer fileCopy.Close()

if _, err = io.Copy(fileCopy, tr); err != nil {
os.Rename(destBackup, dest)
return err
} else {
os.Remove(destBackup)
}
}

Expand Down