[RECREATED] Deal with different file encodings when submitting solutions#184
Merged
kytrinyx merged 3 commits intoexercism:masterfrom Apr 6, 2015
Merged
[RECREATED] Deal with different file encodings when submitting solutions#184kytrinyx merged 3 commits intoexercism:masterfrom
kytrinyx merged 3 commits intoexercism:masterfrom
Conversation
Fixes issue #2303 in the exercism.io project. exercism/exercism#2303 Attempt to detect the charset of a submission so that it can be properly transcoded to UTF-8. Added UTF-16 and UTF-16BE fixture files for the test suite. Changed the tests slightly to deal with different path and newline separators on Windows. Update travis config to include new dependencies.
Contributor
There was a problem hiding this comment.
I think go get -t ./... suffice here. It would fetch all dependencies for each package.
Member
There was a problem hiding this comment.
Yeah, probably. I'll pull this in and then tweak that in a branch to make sure it works.
kytrinyx
added a commit
that referenced
this pull request
Apr 6, 2015
[RECREATED] Deal with different file encodings when submitting solutions
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreating #182 because it is stuck closed after I recreated the branch.
Fixes exercism/exercism#2303