Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 39 additions & 9 deletions config/config.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package config

import (
"bufio"
"bytes"
"encoding/json"
"errors"
"fmt"
Expand Down Expand Up @@ -105,8 +107,16 @@ func (c *Config) Write() error {
}
defer f.Close()

e := json.NewEncoder(f)
return e.Encode(c)
b, err := json.MarshalIndent(c, "", "\t")
if err != nil {
return err
}

if _, err := f.Write(b); err != nil {
return err
}

return nil
}

func (c *Config) load(argPath string) error {
Expand Down Expand Up @@ -149,22 +159,42 @@ func (c *Config) read() error {
if _, serr := f.Seek(0, os.SEEK_SET); serr != nil {
log.Fatalf("seek error: %v", serr)
}
extra = fmt.Sprintf(":\nThe file contains invalid JSON syntax at '%s' <~",
findInvalidJSON(f, serr.Offset))
line, str := findInvalidJSON(f, serr.Offset)
extra = fmt.Sprintf(":\ninvalid JSON syntax at line %d:\n%s",
line, str)
}
return fmt.Errorf("error parsing JSON in the config file %s%s\n%s", f.Name(), extra, err)
}

return nil
}

func findInvalidJSON(f io.ReaderAt, pos int64) string {
buf := make([]byte, 13)
if _, err := f.ReadAt(buf, pos-13); err != nil {
log.Fatalf("read error: %v", err)
func findInvalidJSON(f io.Reader, pos int64) (int, string) {
var (
col int
line int
errLine []byte
)
buf := new(bytes.Buffer)
fb := bufio.NewReader(f)

for c := int64(0); c < pos; {
b, err := fb.ReadBytes('\n')
if err != nil {
log.Fatalf("read error: %v", err)
}
c += int64(len(b))
col = len(b) - int(c-pos)

line++
errLine = b
}

if len(errLine) != 0 {
buf.WriteString(fmt.Sprintf("%5d: %s <~", line, errLine[:col]))
}

return string(buf)
return line, buf.String()
}

// IsAuthenticated returns true if the config contains an API key.
Expand Down
2 changes: 1 addition & 1 deletion config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func TestLoad_InvalidJSON(t *testing.T) {

err = c.load("~/config_invalid.json")
if assert.Error(t, err) {
assert.Contains(t, err.Error(), "The file contains invalid JSON syntax")
assert.Contains(t, err.Error(), "invalid JSON syntax")
}
}

Expand Down